Skip to content

Fix SingleBand pseudocolor band selector bug, index bands from 1 #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfisher87 merged 6 commits into from
Jan 10, 2026
Merged

Fix SingleBand pseudocolor band selector bug, index bands from 1 #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
79a7885
fixing singleband selector bug
nakul-py Nov 20, 2025
9a7b747
Merge branch 'main' into singleband-dropdown
nakul-py Dec 6, 2025
9bcc78a
Merge branch 'main' into singleband-dropdown
mfisher87 Jan 9, 2026
4087bde
reverting changes
nakul-py Jan 10, 2026
3d636fb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 10, 2026
520007a
adding changeset
nakul-py Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/base/src/dialogs/symbology/hooks/useGetBandInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@ import { useEffect, useState } from 'react';

import { loadFile } from '@/src/tools';

export interface IBandHistogram {
buckets: number[];
count: number;
max: number;
min: number;
}

export interface IBandRow {
band: number;
colorInterpretation?: string;
Expand All @@ -30,7 +23,6 @@ const useGetBandInfo = (model: IJupyterGISModel, layer: IJGISLayer) => {
setError(null);

try {
const bandsArr: IBandRow[] = [];
const source = model.getSource(layer?.parameters?.source);
const sourceInfo = source?.parameters?.urls[0];

Expand Down Expand Up @@ -67,9 +59,10 @@ const useGetBandInfo = (model: IJupyterGISModel, layer: IJGISLayer) => {
const image = await tiff.getImage();
const numberOfBands = image.getSamplesPerPixel();

const bandsArr: IBandRow[] = [];
for (let i = 0; i < numberOfBands; i++) {
bandsArr.push({
band: i,
band: i + 1,
stats: {
minimum: sourceInfo.min ?? 0,
maximum: sourceInfo.max ?? 100,
Expand Down
10 changes: 5 additions & 5 deletions packages/base/src/dialogs/symbology/tiff_layer/types/MultibandColor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,10 @@ const MultibandColor: React.FC<ISymbologyDialogProps> = ({
<LoadingOverlay loading={loading} />
<BandRow
label="Red Band"
index={selectedBands.red - 1}
index={selectedBands.red - 1} // IMPORTANT: Bands are 1-indexed
bandRow={bandRows[selectedBands.red - 1]}
bandRows={bandRows}
setSelectedBand={val => updateBand('red', val >= 0 ? val + 1 : 0)}
setSelectedBand={val => updateBand('red', val >= 0 ? val : 0)}
setBandRows={setBandRows}
isMultibandColor={true}
/>
Expand All @@ -142,7 +142,7 @@ const MultibandColor: React.FC<ISymbologyDialogProps> = ({
index={selectedBands.green - 1}
bandRow={bandRows[selectedBands.green - 1]}
bandRows={bandRows}
setSelectedBand={val => updateBand('green', val >= 0 ? val + 1 : 0)}
setSelectedBand={val => updateBand('green', val >= 0 ? val : 0)}
setBandRows={setBandRows}
isMultibandColor={true}
/>
Expand All @@ -152,7 +152,7 @@ const MultibandColor: React.FC<ISymbologyDialogProps> = ({
index={selectedBands.blue - 1}
bandRow={bandRows[selectedBands.blue - 1]}
bandRows={bandRows}
setSelectedBand={val => updateBand('blue', val >= 0 ? val + 1 : 0)}
setSelectedBand={val => updateBand('blue', val >= 0 ? val : 0)}
setBandRows={setBandRows}
isMultibandColor={true}
/>
Expand All @@ -162,7 +162,7 @@ const MultibandColor: React.FC<ISymbologyDialogProps> = ({
index={selectedBands.alpha - 1}
bandRow={bandRows[selectedBands.alpha - 1]}
bandRows={bandRows}
setSelectedBand={val => updateBand('alpha', val >= 0 ? val + 1 : 0)}
setSelectedBand={val => updateBand('alpha', val >= 0 ? val : 0)}
setBandRows={setBandRows}
isMultibandColor={true}
/>
Expand Down
Loading