Group each filter in repository to avoid precedence issues#1156
Open
nirolevy wants to merge 1 commit intogeopython:masterfrom
Open
Group each filter in repository to avoid precedence issues#1156nirolevy wants to merge 1 commit intogeopython:masterfrom
nirolevy wants to merge 1 commit intogeopython:masterfrom
Conversation
Member
|
Thank you @nirolevy for your contribution, we will review this PR. |
@kalxas @tomkralidis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This Pull Request fixes a bug related to the handling of multiple
$ORconditions in a Filter query.When multiple
$ORconditions were present in a query, they were not being combined correctly during the SQL query construction process, leading to incorrect query results or errors. This fix updates the logic inpycsw/core/repository.pyto ensure that a list of logical expressions (filters) is properly combined when constructing the final backend query.Related Issue / Discussion
Closes #1154
Additional Information
Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)