Draft
Conversation
Schaeff
reviewed
Dec 19, 2022
Schaeff
left a comment
Schaeff
left a comment
There was a problem hiding this comment.
Makes sense! Just a few small comments but ok to merge and review together with the rest
zokrates_bellman_plonk/Cargo.toml
Outdated
| zokrates_ast = { version = "0.1", path = "../zokrates_ast", default-features = false } | ||
| zokrates_proof_systems = { version = "0.1", path = "../zokrates_proof_systems", default-features = false } | ||
|
|
||
| bellman_ce = { git = "https://github.com/georgwiese/bellman", rev="b356c7001f30da23bfad2b43eb0b7ca9804c8252", default-features = false, features = ["plonk", "multicore"] } |
There was a problem hiding this comment.
Shall we try to get these changes merged?
Owner
Author
There was a problem hiding this comment.
Sure! I opened matter-labs/bellman#48. Also, I pulled the most recent dev and updated our Cargo.tomls accordingly to make sure that we can actually use the merged version.
zokrates_field/Cargo.toml
Outdated
| # bellman | ||
| bellman_ce = { git = "https://github.com/matter-labs/bellman", version = "^0.3", default-features = false, optional = true } | ||
| bellman_ce = { version = "^0.3", default-features = false, optional = true } | ||
| bellman_ce_plonk = { package = "bellman_ce", git = "https://github.com/georgwiese/bellman", rev="b356c7001f30da23bfad2b43eb0b7ca9804c8252", default-features = false, features = ["plonk", "multicore"], optional = true } |
…nto split-bellman-crate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.