Enhanced Customization for Highlight Styles in Feature Selection

[congchen1101]

Enhanced customization for highlight styles of selected features in FeatureEditor and Identify plugins

• enabled defining highlightStyle object under FeatureEditor and Identify plugins in localConfig.json to allow custome of highlight styles.
• updated and added relevant tests to reflect these changes.
• updated jsdoc for both plugins

On behalf of DB Systel GmbH

Description

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

• Feature

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

• No

[tdipisa]

Dear @congchen1101
thank you so much for your contribution. Is it possible for you to put some screenshots and/or small video in the PR description to show how the functionality you have implemented works and to see how it looks? This will help us with the review. Thank you so much again.

[dsuren1]

@congchen1101
Thank you for your contribution.

Before I proceed with a detailed review, the PR would need to be aligned with the latest master, as there are currently some conflicts with the Map component. I also noticed that the application crashes when the Map viewer is loaded. It might be worth reviewing the IdentifyContainer, as the use of recompose can sometimes interfere with React Hooks. You could consider initializing the plugin configuration directly here

MapStore2/web/client/components/data/identify/enhancers/identify.js

Line 88 in 4108074

onInitPlugin({

Additionally, based on the issue description, it appears the objective is to provide a highlight style for features selected from the Feature Editor. In that case, would it be possible to explore passing this configuration directly to the FeatureEditor, rather than modifying the core Map component?

[tdipisa]

@congchen1101 remind to also fix conflicts. Thank you for your contribution.

[tdipisa]

@congchen1101 is it possible for you to revolve conflicts in your PR and address comment above? This way we can proceed with the review. Thanks.

[congchen1101]

@tdipisa Sorry for the late response and Thank you @dsuren1 very much for your review and suggestions. I’m glad to re-review the PR and resolve the conflicts, but I’ll be able to start on this earliest next week. I hope this is ok for you.

[tdipisa]

@tdipisa Sorry for the late response and Thank you @dsuren1 very much for your review and suggestions. I’m glad to re-review the PR and resolve the conflicts, but I’ll be able to start on this earliest next week. I hope this is ok for you.

Sure @congchen1101 you are in time for v2025.02.02. Thank you very much.

[cla-bot]

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

[cla-bot]

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

[cla-bot]

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

[tdipisa]

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

Thank you for your contrib @congchen1101. Please have a look at this.

[tdipisa]

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

Thank you for your contrib @congchen1101. Please have a look at this.

@congchen1101 we will release v2025.02.02 next week. If you will not be able to provide the CLA signed in the next couple of days by also updating the PR accordingly, I will have to exclude this PR form the upcoming version for now. Thank you so much for understanding.

[congchen1101]

Hi @tdipisa, our internal process still needs some time to handle the CLA. Once we receive approval, I will send you the signed document immediately. If the release is reached, please feel free to proceed without it. Thank you for your understanding.

[tdipisa]

@congchen1101 thank you so much for your feedback.