Update the style of the square buttons and add border radius in all buttons, inputs, selectors#11425
Conversation
|
@subashtiwari1010 I started to review the PR but not completed it yet. You can start to address the changes requested in this initial review, thanks |
There was a problem hiding this comment.
@subashtiwari1010 I just updated the branch with some changes, we still need:
- Check if all test are passing
- Add migration guide explaining the classes square-button-md and square-button-sm are deprecated and replaced by the class square-button
|
@ElenaGallo please test this enhancement on dev, thanks |
|
@subashtiwari1010 after a test I noticed following problems:
I have already reviewed locally and I'll prepare a PR then I'll assign the review to you, thanks |
|
@subashtiwari1010 here the PR to review #11961 |
|
@subashtiwari1010
This button seems not rounded. Is there some css still to align for this? As you requested I report also the following which you confirmed is related. Thank you @subashtiwari1010
|






Description
This PR updates the style of the square buttons, and adds the border radius in button, inputs and selectors as per the requirement in #10954.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
The buttons were categorized in small, medium and default size. And the components did not have the border radius to them.
Fixes #10954
What is the new behavior?
All the buttons are now categorized under
square-buttononly. Other categories of square-button-md and square-button-sm are deprecated. Also, the border radius have been implemented in the button, inputs and select components.Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information