Skip to content

Update the style of the square buttons and add border radius in all buttons, inputs, selectors#11425

Merged
allyoucanmap merged 15 commits intogeosolutions-it:masterfrom
subashtiwari1010:feat/overall-btn-review-10954
Feb 5, 2026
Merged

Update the style of the square buttons and add border radius in all buttons, inputs, selectors#11425
allyoucanmap merged 15 commits intogeosolutions-it:masterfrom
subashtiwari1010:feat/overall-btn-review-10954

Conversation

@subashtiwari1010
Copy link
Contributor

Description

This PR updates the style of the square buttons, and adds the border radius in button, inputs and selectors as per the requirement in #10954.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
The buttons were categorized in small, medium and default size. And the components did not have the border radius to them.
Fixes #10954

What is the new behavior?
All the buttons are now categorized under square-button only. Other categories of square-button-md and square-button-sm are deprecated. Also, the border radius have been implemented in the button, inputs and select components.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@allyoucanmap
Copy link
Contributor

@subashtiwari1010 I started to review the PR but not completed it yet. You can start to address the changes requested in this initial review, thanks

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 4, 2025
@tdipisa tdipisa modified the milestones: 2025.02.00, 2026.01.00 Nov 4, 2025
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 4, 2025
@cla-bot cla-bot bot added the CLA Ready label Feb 5, 2026
Copy link
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subashtiwari1010 I just updated the branch with some changes, we still need:

  • Check if all test are passing
  • Add migration guide explaining the classes square-button-md and square-button-sm are deprecated and replaced by the class square-button

@allyoucanmap allyoucanmap merged commit 3431b19 into geosolutions-it:master Feb 5, 2026
12 checks passed
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test this enhancement on dev, thanks

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Feb 5, 2026

@subashtiwari1010 after a test I noticed following problems:

  • button groups in some cases was not rendering correctly
image image
  • Problem in spacing of forms (I don't think is directly connected to this one but it needs to be solved)
image
  • Even if square-button-md and square-button-sm are deprecated we don't provide a fallback

I have already reviewed locally and I'll prepare a PR then I'll assign the review to you, thanks

@allyoucanmap
Copy link
Contributor

@subashtiwari1010 here the PR to review #11961

@tdipisa
Copy link
Member

tdipisa commented Feb 6, 2026

@subashtiwari1010
New rounded buttons are very nice. At a very first look I only noticed this

image

This button seems not rounded. Is there some css still to align for this?

As you requested I report also the following which you confirmed is related. Thank you @subashtiwari1010

image

@subashtiwari1010
Copy link
Contributor Author

subashtiwari1010 commented Feb 6, 2026

Here is some issues in the filter widget:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review overall app buttons style

4 participants