Fix fetchOptions: {throw: true}
#241
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
fetchOptions: {throw: true}on your auth client, all authenticated convex functions will fail with "unauthenticated".This is because
fetchAccessTokenassumes thatauthClient.convex.token()will return{data, error}. When throw is set to true, it just returns the data as is.This PR sets fetch: false to this one call so the returned object is always correct. Not 100% sure if this is the cleanest solution, but this is the only time the users authClient itself is used anywhere in the package so i imagine its probably fine. Just wanted to submit a fix of some kind :)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.