Support in Admin plugin to upload Fontawesome 6 icons using Iconpicker#2445
Open
pmoreno-rodriguez wants to merge 1 commit intogetgrav:developfrom
Open
Support in Admin plugin to upload Fontawesome 6 icons using Iconpicker#2445pmoreno-rodriguez wants to merge 1 commit intogetgrav:developfrom
pmoreno-rodriguez wants to merge 1 commit intogetgrav:developfrom
Conversation
Member
|
Is this the free stuff only? If we were to do this, we should probably upadte the icons in the Admin plugin also. The only issue is that there was some additional items in forkawesome that were added after 4.7. |
Contributor
Author
|
In fact this PR is for the Admin plugin, and includes Fontawesome fonts version 6 (only free icons). You can try it yourself if you want in a clean Grav installation. Obviously, the creators of themes and plugins should adapt their code, because in Fontawesome 6 there is more than one prefix, not just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I've made some changes to the admin plugin to support the latest Fontawesome 6 version for Iconpicker buttons, which until now were displaying icons from Forkawesome, which was based on Fontawesome 4.7, and quite outdated.
Do you think it's feasible to add this functionality to Grav for its upcoming 1.8 release?
I'll give you a couple of screenshots