Fix admin recovery crash when blueprints.fields is null#2485
Closed
onlsol wants to merge 72 commits intogetgrav:developfrom
Closed
Fix admin recovery crash when blueprints.fields is null#2485onlsol wants to merge 72 commits intogetgrav:developfrom
onlsol wants to merge 72 commits intogetgrav:developfrom
Conversation
Release v1.10.49.1 # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCAAdFiEEwbiolRD/eEYBHGp5nyzziuvbCuAFAmi44PAACgkQnyzziuvb # CuD1HA/+OGUPdLrU46H9e4XXxKF+TAN/1xggdHhHoCef58YNTNPLYS40x3d0JGb2 # LPg3g0Iy/0AJboeXUdWKtdDSPGWg6x2dVddsDo4v/OYchLftHy6HOkSFhmw0bpQD # iz7vBcX2zfd7VxhoGt5p8NDYFCZ7hGjXbqVg1Xyd7sqTGT6nRMl52SK5mbTul5AM # EzTepF7Cl95y/3bWdySqiRY+955gCWI+j2mZwwL0rN2/R9eu8+z2JZWilkloDOn8 # d6A12rTvfJvsu5ZtrgtEJVNJzcwSCbvuA/k43t0YE532UJPlpIkIUrbwTYUiAEZL # PFu9OwmNLZ7FYyRejJZHoGIF/9cJMc43p5PMuPVbx2ppcc65Ugr9SmnqkkJ4pvOq # OIaoB/ZK1OC7GJkCZ6GfEWFnT4XsqB7d0xCmk5ch9c71jn7mDR/88fk3DzMA0/OI # uFKgFevxw1At7sZMhyhc+F19z/XYCk+s9WkJT9AQMD2zBfGNGwaSiGnr2gdOHGEC # G3yeFs8ixwnfVSnSfEVtdzYhM7+Ah9MNnpqdGTyY1ny7zfdBy8su6cB0a78WYYxj # izIm6tjLm42moTMdrOB4OcTqk89zDEiePsf/hHAUt7/CaHWpXPZeavWiTnqspUF9 # rVRKSHaAYU8PmMc7wRXn3a8R2chGb6X+P8oW8DMVmbsa+5vwrxk= # =NjBq # -----END PGP SIGNATURE----- # gpg: Signature made Wed Sep 3 18:44:32 2025 MDT # gpg: using RSA key C1B8A89510FF7846011C6A799F2CF38AEBDB0AE0 # gpg: Good signature from "Andy Miller <rhuk@mac.com>" [ultimate]
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
This reverts commit d437bd1.
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Release v1.10.50 # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCAAdFiEEwbiolRD/eEYBHGp5nyzziuvbCuAFAmkXTbEACgkQnyzziuvb # CuDW5BAArQLCnU/02r4r73WQ50FfojJOnH8+i0K2zTVVtheNvUsbOEbYTokCPrrQ # 5udhL1Psd004g3M0uiKYAv10D3GmRuBi+q8LZaI+AMDRY1dDURjDSzKL70FTqgUa # TEQX5snT0tuPRUzS27hJi3l7P27WNQwK29Pl0m+JDAUcqzoqFZZzJoawQRBRnfeH # AnmhocPNOYIV23RsQzE5XzO0Y0SAz8DbFLoUVyVMP+Cr2YuP7wqd0cSjkqFh+FS4 # eLGjPj7OA+oBHDoiaITlAMXCAH7mpmCnxPqjOKLdR9S6C7/btAWa1p+j3nLLv1od # h2nM/e5K+pxg7eb3BHK0Xs2j5YNl7RfgKspg3BeSVueOTCniaPC8lzexp0MlIaKn # Aulc7g7egb75LEknDpgt7vM636Vbv/noxMeqgwyxMnhJ60iojq6Hsxtk9u/699kL # /1s+a4VjkGPgxQHqErNu4ig9gFPA1nHNwwW2ngXU+5F44lKD+025bgMPqjEutGaR # waYEp6t8hp6IUJM3CI8NidxPlnU82kSHUAhem16k9cDxhsau8DsST91enqdREt4G # xdqxyBLOQDLlPhtlMNfdh1ojrbUQx+UUdVcMnmPWpO4y+BHRqRmFIhb0W+wPdxCt # PwIt/55ICTR57HzVXvAX4k0nkFCj4Go5x0Gj6sPbGCOql/zyTwg= # =elGV # -----END PGP SIGNATURE----- # gpg: Signature made Fri Nov 14 15:41:37 2025 GMT # gpg: using RSA key C1B8A89510FF7846011C6A799F2CF38AEBDB0AE0 # gpg: Good signature from "Andy Miller <rhuk@mac.com>" [ultimate]
Signed-off-by: Andy Miller <rhuk@mac.com>
Signed-off-by: Andy Miller <rhuk@mac.com>
Member
|
Bad pull request.. 47 files changes can't be correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Admin can go into recovery mode with:
when rendering blueprints where
blueprints.fieldsisnull.Steps to reproduce
form/fields, soblueprints.fieldsends upnull.Technical details
In the Admin plugin there are two twig templates that call
Admin::findFormFields()like this:{% if admin.findFormFields('file', blueprints.fields) %}