Fix padding around notice blocks #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because blocks are using paragraph tags, top and bottom block padding is dependant on the margin of the global `<p>` style configuration. For example, in learn2-git theme global paragraph configuration has a top/bottom margin of 1.7rem (~30px). Current CSS matches this, it becomes an issue when one wants to use markdown blocks in other themes, where different font is used with, let's say, Arial with 1.2rem for paragraph top/bottom margins. We solve this issue by reseting margin of paragraph tags inside notices to zero and purely using just padding to provide a spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because blocks are using paragraph tags, top and bottom block padding is dependent on the margin of the global
<p>style configuration. For example, inlearn2-gittheme global paragraph configuration has a top/bottom margin of 1.7rem (~30px). Current CSS matches this, however it becomes an issue when one wants to use markdown blocks in other themes, where different font is used, let's say, Arial with 1.2rem for paragraph top/bottom margins.We solve this issue by resetting margin of paragraph tags inside notices to zero and purely relying just on padding to provide a spacing.
This correctly fixes a padding issue mentioned in #5 and later reverted in #6 .
This also fixes an issue mentioned in #24 with current default themes where there is no right padding:
