Conversation
with new languages files
with new languages files
with new languages files
with new options and languages files
rhukster
requested changes
Nov 28, 2017
Member
rhukster
left a comment
rhukster
left a comment
There was a problem hiding this comment.
Overall a great improvement. I do have one concern about the current langs tho. If you can sort that i'll gladly merge.
| THEME_LEARN2_CLEAR_HISTORY: Clear History | ||
| THEME_LEARN2_BUILT_WITH_GRAV: Built with <a href="http://getgrav.org">Grav</a> - The Modern Flat File CMS | ||
| THEME_LEARN2_SEARCH_DOCUMENTATION: Search Documentation | ||
| cn: |
Member
There was a problem hiding this comment.
We are losing support for some languages by simply deleting this file and replacing it with en, fr. You should at least create files for these languages with only these few translations in them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
options @ ./blueprints.yaml
languages