Conversation
|
The one-letter typo is indeed a mistake, but I don't understand why you're making the other changes? |
|
I figured it would be less error prone and more expressive to make the generated random id into a variable ( instead of repeating 'stockIds[stockIdx]' through the function ). |
|
I know it's probably not the right forum for this, but anyway... |
|
For now I prefer to only fix typos, not make substantive changes. I would defer those changes for a second edition. A reduced PR for this typo (with potentially a separate issur/PR for the other suggestions) would be appreciated. Thanks! |
|
Opened a new PR #160 with just the typo fix. I'm not sure what to do with this PR, I guess you can close it, or leave it for future reference/suggestion as you offered. |
stockId was mistakenly written as stockIdx