Skip to content

Conversation

@github-actions
Copy link
Contributor

Bumps scripts/update-android.sh from 8.24.0 to 8.25.0.

Auto-generated by a dependency updater.

Changelog

8.25.0

Fixes

  • [ANR] Removed AndroidTransactionProfiler lock (#4817)
  • Avoid ExecutorService for DefaultCompositePerformanceCollector timeout (#4841)
    • This avoids infinite data collection for never stopped transactions, leading to OOMs
  • Fix wrong .super() call in SentryTimberTree (#4844)

Improvements

  • [ANR] Defer some class availability checks (#4825)
  • Collect PerformanceCollectionData only for sampled transactions (#4834)
    • Breaking change: Transactions with a deferred sampling decision (sampled == null) won't be collecting any performance data anymore (CPU, RAM, slow/frozen frames).

Dependencies

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh/8.25.0 branch from 8d760eb to 76e4cdf Compare October 30, 2025 03:23
group = io.sentry
version = 6.0.0-alpha.6
sdk_version = 8.24.0
sdk_version = 8.25.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The AndroidOkHttpInstallStrategy's maxSupportedSentryVersion (6.x) is too low for the new sdk_version (8.x), preventing sentry-android-okhttp auto-installation.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The AndroidOkHttpInstallStrategy defines maxSupportedSentryVersion as SemVer(6, 9999, 9999). When the sdk_version is updated to 8.25.0, the AbstractInstallStrategy's check sentrySemVersion > maxSupportedSentryVersion evaluates to true (8.25.0 > 6.9999.9999). This condition causes the sentry-android-okhttp module to be silently skipped during auto-installation, leading to missing integration and potential runtime errors when using OkHttp with Sentry.

💡 Suggested Fix

Update maxSupportedSentryVersion in AndroidOkHttpInstallStrategy.kt to reflect compatibility with Sentry SDK version 8.x or higher, or remove the maxSupportedSentryVersion override if it's no longer necessary.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: plugin-build/gradle.properties#L11

Potential issue: The `AndroidOkHttpInstallStrategy` defines `maxSupportedSentryVersion`
as `SemVer(6, 9999, 9999)`. When the `sdk_version` is updated to 8.25.0, the
`AbstractInstallStrategy`'s check `sentrySemVersion > maxSupportedSentryVersion`
evaluates to true (8.25.0 > 6.9999.9999). This condition causes the
`sentry-android-okhttp` module to be silently skipped during auto-installation, leading
to missing integration and potential runtime errors when using OkHttp with Sentry.

Did we get this right? 👍 / 👎 to inform future reviews.

@romtsn romtsn merged commit 2618def into main Oct 30, 2025
17 checks passed
@romtsn romtsn deleted the deps/scripts/update-android.sh/8.25.0 branch October 30, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants