-
-
Notifications
You must be signed in to change notification settings - Fork 37
feat(distribution): Add install-groups support #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
runningcode
wants to merge
2
commits into
main
Choose a base branch
from
no/add-install-groups-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for install groups in the distribution extension to control update visibility between builds. Install groups allow separation of distribution channels (e.g., "internal", "beta", "production") so that only builds with matching install groups can see updates for each other. Changes: - Add installGroups property to DistributionExtension - Wire installGroups through SentryUploadAppArtifactTask to generate --install-group CLI arguments for sentry-cli - Add installGroups to GenerateDistributionPropertiesTask to write io.sentry.distribution.install-groups-override property - Add comprehensive tests for all new functionality The feature is forward-compatible with sentry-cli 3.1.0 (ignores unknown flags) and will automatically activate when sentry-cli is upgraded to 3.2.0+. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
| - Add upload functionality for [Size Analysis](https://docs.sentry.io/platforms/android/size-analysis/) ([#915](https://github.com/getsentry/sentry-android-gradle-plugin/pull/915)) | ||
| - Add upload functionality for [Build Distribution](https://docs.sentry.io/platforms/android/build-distribution/) ([#986](https://github.com/getsentry/sentry-android-gradle-plugin/pull/986)) | ||
| - Auto-install for [Auto-Update Build Distribution](https://docs.sentry.io/platforms/android/build-distribution/auto-update/) SDK when enabled for variant ([#1001](https://github.com/getsentry/sentry-android-gradle-plugin/pull/1001)) | ||
| - Add install groups support for Build Distribution to control update visibility between distribution channels ([#1070](https://github.com/getsentry/sentry-android-gradle-plugin/pull/1070)) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 The changelog entry seems to be part of an already released section
## 6.0.0.
Consider moving the entry to the## Unreleasedsection, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for install groups in the distribution extension to control update visibility between builds. This feature enables separation of distribution channels (e.g., "internal", "beta", "production") so that only builds with matching install groups can see updates for each other.
Changes
installGroups: SetProperty<String>toDistributionExtensionwith comprehensive documentationinstallGroupsthroughSentryUploadAppArtifactTaskto generate--install-group <group>CLI argumentsinstallGroupstoGenerateDistributionPropertiesTaskto writeio.sentry.distribution.install-groups-overrideproperty as comma-separated stringAndroidComponentsConfigto pass install groups from extension to tasksUsage
Users can now configure install groups like this:
sentry { distribution { enabled.set(true) installGroups.set(setOf("internal", "beta")) authToken.set(System.getenv("SENTRY_DISTRIBUTION_AUTH_TOKEN")) } }