Open
Conversation
Contributor
|
denrase
requested changes
Jul 8, 2025
buenaflor
commented
Jul 17, 2025
Comment on lines
3
to
+10
| class ConfigFormatter { | ||
| static String formatConfig( | ||
| String config, ConfigFileType fileType, String? url) { | ||
| // Add URL if provided | ||
| if (url != null) { | ||
| config = _addUrlPrefix(config, fileType, url); | ||
| String config, | ||
| ConfigFileType fileType, | ||
| String? url, | ||
| ) { | ||
| if (url?.isNotEmpty == true) { | ||
| config = _addUrlPrefix(config, fileType, url!); |
Contributor
Author
There was a problem hiding this comment.
eventually we should rewrite the test to not rely on things like normalizing the pubspec and properties file to a string.
adding more and more business logic to test code is generally not good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds support for ignoring files and directories when uploading sourcemaps and sources for Flutter Web
💡 Motivation and Context
Closes #329
💚 How did you test it?
📝 Checklist
🔮 Next steps