feat(span-first): add span v2 support for frames tracking#3447
feat(span-first): add span v2 support for frames tracking#3447buenaflor wants to merge 40 commits intofeat/span-firstfrom
Conversation
|
packages/flutter/lib/src/frames_tracking/span_frame_metrics_collector_v2.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/frames_tracking/span_frame_metrics_collector_v2.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/integrations/frames_tracking_integration.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/frames_tracking/span_frame_metrics_collector_v2.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/frames_tracking/span_frame_metrics_collector_v2.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/frames_tracking/span_frame_metrics_collector_v2.dart
Outdated
Show resolved
Hide resolved
| final collector = SpanFrameMetricsCollectorV2(framesTracker, | ||
| resumeFrameTracking: () => widgetsBinding.resumeTrackingFrames(), | ||
| pauseFrameTracking: () => widgetsBinding.pauseTrackingFrames()); | ||
| _collector = collector; |
There was a problem hiding this comment.
We did implement a V2 perfomrce collector, but are not adding it to options, is this correct?
There was a problem hiding this comment.
it's a behaviour difference.
for transactions we add it to the options so we can manually trigger onSpanFinish and onSpanEnded via options.collector.onSpanFinished() but now that we use lifecycle callbacks we dont need to do that anymroe for spanv2 so we dont need to add it to the options
I'll refactor the static version to use lifeecycle callbacks as well
packages/flutter/lib/src/integrations/frames_tracking_integration.dart
Outdated
Show resolved
Hide resolved
I checked and probably not, this specific integration requires lots of concrete specific usages, the abstraction wouldn't help here |
packages/flutter/lib/src/frames_tracking/span_frame_metrics_collector_v2.dart
Outdated
Show resolved
Hide resolved
packages/dart/lib/src/tracing/instrumentation/instrumentation_span.dart
Outdated
Show resolved
Hide resolved
packages/flutter/lib/src/frames_tracking/span_frame_metrics_collector.dart
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
📜 Description
Part of span-first
💡 Motivation and Context
Part of #3334
💚 How did you test it?
Manual, unit/widget test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
#skip-changelog