Add SentryOptions.DisableSentryHttpMessageHandler#3879
Merged
jamescrosswell merged 5 commits intomainfrom Jan 12, 2025
Merged
Conversation
bruno-garcia
approved these changes
Jan 9, 2025
Member
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
Can we flip this to false automagically if OpenTelemetry.Instrumentation.Http is installed? If so, do we need a public options or would internal with InternalsVisibleTo be enough?
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add SentryOptions.DisableSentryHttpMessageHandler ([#3879](https://github.com/getsentry/sentry-dotnet/pull/3879))If none of the above apply, you can opt out of this check by adding |
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the duplicate trace problem described in #3843:
Essentially we allow SDK users to disable the
SentryHttpMessageHandlerif they are already using theOpenTelemetry.Instrumentation.Httppackage to trace outbound requests... to avoid duplicate instrumentation.This PR does not address any issues around YARP - that would require separate exploration.