-
-
Notifications
You must be signed in to change notification settings - Fork 229
feat: Add support to send OTEL traces via OTLP #4899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamescrosswell
wants to merge
19
commits into
main
Choose a base branch
from
oltp-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+892
−134
Open
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2122abb
Added support to send OTEL traces via OTLP
jamescrosswell a2fb0e4
Added OTEL propagation context to link OTEL spans to events etc.
jamescrosswell 442fc7d
Disable Sentry tracing instrumentation if OTEL is enabled
jamescrosswell 08d8711
Revert to classic extension methods
jamescrosswell 907850b
Added option to disable sentry tracing
jamescrosswell 6f8312d
Added some new tests... found some new issues
jamescrosswell 8fbbf89
Merge remote-tracking branch 'origin/main' into oltp-integration
jamescrosswell 1ea156a
Prevent Hub.GetBaggage from throwing an exception
jamescrosswell 83f9097
Fix tests
jamescrosswell ee67a6e
Bump to Otel 1.15.0 to address IL3050 error for AOT compilation
jamescrosswell d1597d8
changelog
jamescrosswell c8856a6
Fixed package downgrades
jamescrosswell 5ee6455
Fixed failing tests on .NET Framework
jamescrosswell 46eb4d6
Merge branch 'main' into oltp-integration
jamescrosswell af2457b
Format code
getsentry-bot ed9e04d
Moved to a separate NuGet package
jamescrosswell 304c5bc
.
jamescrosswell 4537ac9
.
jamescrosswell d2406ef
Updated Samples
jamescrosswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,7 @@ | |
| <PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.8.1" /> | ||
| <PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.8.1" /> | ||
| <PackageReference Include="OpenTelemetry.Instrumentation.Runtime" Version="1.8.0" /> | ||
| <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.8.1" /> | ||
|
||
| </ItemGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(Configuration)' == 'Release'"> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunately a bit more complex for SDK users to initialise because the
TracerProviderBuilder.AddOtlpExportermethod has no override with anIServiceProviderparameter (so there's no way to read the DSN from the sentry options that get added to the service registry later on).