ci: Skip device tests for non-mobile PRs #4909
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,8 +6,34 @@ on: | |
| - main | ||
| - release/* | ||
| pull_request: | ||
| paths: | ||
| # Core SDK (transitive dependency of all mobile packages) | ||
| - 'src/Sentry/**' | ||
| - 'src/Sentry.Extensions.Logging/**' | ||
| # Mobile-specific packages | ||
| - 'src/Sentry.Maui/**' | ||
| - 'src/Sentry.Maui.CommunityToolkit.Mvvm/**' | ||
| - 'src/Sentry.Bindings.Android/**' | ||
| - 'src/Sentry.Bindings.Cocoa/**' | ||
| - 'src/Sentry.Android.AssemblyReader/**' | ||
| # Device test app and test projects that run on device | ||
| - 'test/Sentry.Maui.Device.TestApp/**' | ||
| - 'test/Sentry.Tests/**' | ||
| - 'test/Sentry.Extensions.Logging.Tests/**' | ||
| - 'test/Sentry.Maui.Tests/**' | ||
| - 'test/Sentry.Maui.CommunityToolkit.Mvvm.Tests/**' | ||
| - 'test/Sentry.Android.AssemblyReader.Tests/**' | ||
| - 'test/Sentry.Testing/**' | ||
| # Integration tests | ||
| - 'integration-test/android.Tests.ps1' | ||
| - 'integration-test/ios.Tests.ps1' | ||
| - 'integration-test/net9-maui/**' | ||
| # Scripts, native modules, and CI | ||
| - 'scripts/device-test.ps1' | ||
| - 'scripts/device-test-utils.ps1' | ||
| - 'modules/sentry-native/**' | ||
| - '.github/workflows/device-tests-android.yml' | ||
| - '.github/actions/**' | ||
|
Comment on lines
+9
to
+50
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment. Accepted (mostly). Added the following missing paths in 835075a:
Rejected Rejected
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously this workflow would not run for PRs that only changed
*.mdfiles. Withpull_request.pathsalone, a docs-only change under a listed directory (e.g.src/Sentry/**/README.md) will now trigger the full device test suite. If you want to preserve the prior behavior, add apull_request.paths-ignoreentry for**/*.mdalongsidepaths.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rejected. GitHub Actions does support combining
pathsandpaths-ignore, but this is an extremely rare edge case — someone would need to edit a markdown file insidesrc/Sentry/(these source directories almost never contain .md files). The cost of a false trigger is just one unnecessary CI run, while addingpaths-ignoreadds complexity for near-zero benefit. The push trigger on main/release catches everything anyway.