-
-
Notifications
You must be signed in to change notification settings - Fork 229
ci: Use Cirrus Runners for iOS integration tests #4951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
1df212b
192b825
25b97b3
04a5b89
7f51356
175a733
ebc5740
aff5bf1
841dbc3
7d8d1ed
3776ef8
6ec1266
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,12 @@ | |
| _logger = Substitute.ForPartsOf<TestOutputDiagnosticLogger>(testOutputHelper); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void This_Test_Should_Fail() | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. todo: remove I added this to see a test failure in CI ... to double check against a false negative |
||
| { | ||
| Assert.True(SentrySdk.IsEnabled); | ||
|
Check failure on line 32 in test/Sentry.Tests/SentrySdkTests.cs
|
||
| } | ||
|
|
||
| [Fact] | ||
| public void IsEnabled_StartsOffFalse() | ||
| { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these never triggered, I am not sure about the reason.
The tag might be wrong, it should be just 26.2 (see https://github.com/cirruslabs/macos-image-templates/pkgs/container/macos-tahoe-xcode/676398842?tag=26.2)
But I can suggest adding this to ensure they execute in FIFO: https://cirrus-runners.app/setup/#concurrency-groups-fifo-scheduling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.