Skip to content

fix: MSB4006 circular dependency involving target "SetupCocoaSDK" #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: MSB4006 circular dependency involving target "SetupCocoaSDK" #4956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bbb6e6
fix: MSB4006 circular dependency involving target "SetupCocoaSDK"
jamescrosswell Feb 25, 2026
46b325a
changelog
jamescrosswell Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixes

- The SDK now logs a `Warning` instead of an `Error` when being ratelimited ([#4927](https://github.com/getsentry/sentry-dotnet/pull/4927))
- Occassional MSB4006 circular dependency errors involving target "SetupCocoaSDK" when building the SDK ([#4956](https://github.com/getsentry/sentry-dotnet/pull/4956))

## 6.2.0-alpha.0

Expand Down
22 changes: 16 additions & 6 deletions src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,17 +103,25 @@
DependsOnTargets="_DownloadCocoaSDK;_BuildCocoaSDK;_GenerateSentryCocoaBindings;SanitizeSentryCocoaFramework"
Condition="$([MSBuild]::IsOSPlatform('OSX'))" />

<!-- Setup exactly once: https://learn.microsoft.com/visualstudio/msbuild/run-target-exactly-once -->
<!--
Outer build (multi-TFM): runs _SetupCocoaSDK once before MSBuild fans out to inner per-TFM builds.
Critically, this ensures the stamp file exists before the inner builds are scheduled, so
SetupCocoaSDK's Condition (which checks for the stamp) correctly skips all inner builds.
-->
<Target Name="SetupCocoaSDKBeforeOuterBuild" DependsOnTargets="_SetupCocoaSDK"
Condition="$([MSBuild]::IsOSPlatform('OSX'))"
BeforeTargets="DispatchToInnerBuilds" />

<!--
Inner build (single-TFM) or direct single-TFM invocation (-f flag): runs _SetupCocoaSDK as a
direct dependency, without a recursive MSBuild call. The recursive call pattern caused a circular
dependency (SetupCocoaSDK → BeforeBuild → SetupCocoaSDK) that newer MSBuild versions detect as an error.
All subtargets are idempotent, so if the outer build already ran them this is a no-op.
-->
<Target Name="SetupCocoaSDK"
DependsOnTargets="_SetupCocoaSDK"
BeforeTargets="BeforeBuild"
Condition="$([MSBuild]::IsOSPlatform('OSX'))">
<!-- Setup exactly once: https://learn.microsoft.com/visualstudio/msbuild/run-target-exactly-once -->
<MSBuild Projects="$(MSBuildProjectFullPath)" Targets="_SetupCocoaSDK" RemoveProperties="TargetFramework" />
</Target>
Condition="$([MSBuild]::IsOSPlatform('OSX'))" />

<Target Name="CleanCocoaSDK" AfterTargets="Clean" Condition="$([MSBuild]::IsOSPlatform('OSX'))">
<RemoveDir Directories="$(SentryCocoaCache)" ContinueOnError="true" />
Expand All @@ -133,10 +141,12 @@
</Target>

<!-- Sanitize the xcframework before NativeReference resolution and packing -->
<!-- Stamp file ensures this only runs once even when invoked from multiple inner TFM builds -->
<Target Name="SanitizeSentryCocoaFramework"
Condition="$([MSBuild]::IsOSPlatform('OSX')) and Exists('$(SentryCocoaFramework)')">
Condition="$([MSBuild]::IsOSPlatform('OSX')) and Exists('$(SentryCocoaFramework)') and !Exists('$(SentryCocoaFramework).sanitized.stamp')">
<Message Importance="High" Text="Sanitizing $(SentryCocoaFramework): removing dSYMs, Headers, Modules, PrivateHeaders (including symlinks)." />
<Exec Command="find &quot;$(SentryCocoaFramework)&quot; -depth \( -name dSYMs -o -name Headers -o -name Modules -o -name PrivateHeaders \) -exec echo Removing {} \; -exec rm -rf {} + 2&gt;/dev/null || true" />
<Touch Files="$(SentryCocoaFramework).sanitized.stamp" AlwaysCreate="true" />
</Target>

<!-- Workaround for https://github.com/xamarin/xamarin-macios/issues/15299 -->
Expand Down
Loading