feat(feedback): Report a Bug button#4378
Merged
antonis merged 154 commits intofeedback-ui-2from Apr 7, 2025
Merged
Conversation
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Contributor
Author
|
Thank you for reviewing and your feedback @krystofwoldrich 🙇
Good catch 👍 Should be fixed after 04f1a8d
Good point! Added with 7473c58
Good catch 👍 Added the border with 24b3df0 |
…ct-Button # Conflicts: # CHANGELOG.md
antonis
changed the title
antonis
commented
Apr 3, 2025
|
|
||
| const showFeedbackWidget = (): void => { | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| const { showFeedbackWidget } = require('./FeedbackWidgetManager'); |
Contributor
Author
There was a problem hiding this comment.
The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718
This was referenced Apr 3, 2025
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button
krystofwoldrich
approved these changes
Apr 7, 2025
Contributor
krystofwoldrich
left a comment
krystofwoldrich
left a comment
There was a problem hiding this comment.
Looks good. Thank you! 🚀
Can you also add the button to the Expo Sample?
Contributor
Author
|
Thank you for reviewing and all the feedback Krystof 🙇
Added with 722114d |
This was referenced Apr 7, 2025
6 tasks
antonis
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 4, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. -->⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. -->⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
bitsandfoxes
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. -->⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Targeting
feedback-ui-2branchPR Chain:
📜 Description
Implements feedback button that launches the feedback widget using the auto-injected feedback widget
The button is shown with
Sentry.showFeedbackButton()and hidden withSentry.hideFeedbackButton()provided that the app is wrapped (Sentry.wrap(RootComponent)). The button can be styled like:💡 Motivation and Context
Part of #4302
💚 How did you test it?
Manual testing with the sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps