chore(test): Fixes RNSentryAndroidTester compatibility with AS Ladybug#4409
Merged
chore(test): Fixes RNSentryAndroidTester compatibility with AS Ladybug#4409
Conversation
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ae23a7 | 526.83 ms | 513.38 ms | -13.45 ms |
| 61310e1 | 464.42 ms | 452.47 ms | -11.95 ms |
| 13f280b | 486.16 ms | 472.45 ms | -13.71 ms |
| c6f01ea | 486.20 ms | 486.98 ms | 0.77 ms |
| 1d86dd6 | 405.14 ms | 411.06 ms | 5.92 ms |
| cdf2bdf | 448.42 ms | 443.42 ms | -5.00 ms |
| de59d3a | 486.48 ms | 495.66 ms | 9.18 ms |
| f06c879 | 408.41 ms | 424.54 ms | 16.13 ms |
| d2c32bb | 448.85 ms | 450.19 ms | 1.34 ms |
| 8ab11b6 | 462.10 ms | 450.40 ms | -11.70 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ae23a7 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| 61310e1 | 17.74 MiB | 20.08 MiB | 2.35 MiB |
| 13f280b | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| c6f01ea | 17.74 MiB | 20.10 MiB | 2.36 MiB |
| 1d86dd6 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
| cdf2bdf | 17.74 MiB | 20.10 MiB | 2.36 MiB |
| de59d3a | 17.74 MiB | 20.10 MiB | 2.36 MiB |
| f06c879 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
| d2c32bb | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 8ab11b6 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
Contributor
Author
|
There seems to be an issue with Boost availability affecting both the Android and iOS metric tests. This seems unrelated with this PR. |
Contributor
Author
Opened an issue to track the CI failure and resolve it |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5bc97b+dirty | 1230.63 ms | 1234.83 ms | 4.20 ms |
| 205982c+dirty | 1226.83 ms | 1234.36 ms | 7.53 ms |
| 57448c5+dirty | 1228.73 ms | 1235.90 ms | 7.16 ms |
| b1e8712+dirty | 1256.02 ms | 1265.14 ms | 9.12 ms |
| 946a600+dirty | 1238.20 ms | 1236.85 ms | -1.35 ms |
| b8ff156+dirty | 1236.51 ms | 1234.53 ms | -1.98 ms |
| 0ebca77+dirty | 1220.75 ms | 1222.81 ms | 2.06 ms |
| 9385d74+dirty | 1215.18 ms | 1216.43 ms | 1.25 ms |
| 9dabcce+dirty | 1231.39 ms | 1238.02 ms | 6.63 ms |
| 690220d+dirty | 1228.27 ms | 1233.55 ms | 5.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5bc97b+dirty | 2.36 MiB | 3.10 MiB | 753.14 KiB |
| 205982c+dirty | 2.36 MiB | 3.11 MiB | 760.04 KiB |
| 57448c5+dirty | 2.36 MiB | 3.10 MiB | 752.34 KiB |
| b1e8712+dirty | 2.36 MiB | 2.84 MiB | 488.84 KiB |
| 946a600+dirty | 2.36 MiB | 3.10 MiB | 759.74 KiB |
| b8ff156+dirty | 2.36 MiB | 3.11 MiB | 759.80 KiB |
| 0ebca77+dirty | 2.36 MiB | 3.04 MiB | 698.33 KiB |
| 9385d74+dirty | 2.36 MiB | 3.10 MiB | 759.78 KiB |
| 9dabcce+dirty | 2.36 MiB | 3.10 MiB | 757.52 KiB |
| 690220d+dirty | 2.36 MiB | 3.10 MiB | 753.57 KiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8fe7c9d+dirty | 363.91 ms | 429.93 ms | 66.03 ms |
| 83f6f6c+dirty | 442.82 ms | 487.48 ms | 44.66 ms |
| f06c879+dirty | 361.27 ms | 407.88 ms | 46.61 ms |
| d16beca+dirty | 389.49 ms | 423.86 ms | 34.37 ms |
| b95b8af+dirty | 392.94 ms | 428.00 ms | 35.06 ms |
| ac41368+dirty | 395.91 ms | 451.17 ms | 55.26 ms |
| 9dabcce+dirty | 359.66 ms | 430.73 ms | 71.08 ms |
| c639edf+dirty | 363.39 ms | 414.78 ms | 51.39 ms |
| 79976dd+dirty | 373.25 ms | 404.64 ms | 31.39 ms |
| 70caa60+dirty | 308.83 ms | 393.06 ms | 84.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8fe7c9d+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 83f6f6c+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| f06c879+dirty | 7.15 MiB | 8.12 MiB | 997.78 KiB |
| d16beca+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| b95b8af+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| ac41368+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| 9dabcce+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| c639edf+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 79976dd+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 70caa60+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5bc97b+dirty | 1229.17 ms | 1227.64 ms | -1.54 ms |
| 205982c+dirty | 1228.06 ms | 1237.72 ms | 9.66 ms |
| 57448c5+dirty | 1244.65 ms | 1249.20 ms | 4.55 ms |
| b1e8712+dirty | 1284.11 ms | 1297.82 ms | 13.71 ms |
| 946a600+dirty | 1236.12 ms | 1234.94 ms | -1.18 ms |
| b8ff156+dirty | 1238.92 ms | 1239.57 ms | 0.66 ms |
| 0ebca77+dirty | 1209.30 ms | 1220.33 ms | 11.03 ms |
| 9385d74+dirty | 1239.51 ms | 1245.88 ms | 6.37 ms |
| 9dabcce+dirty | 1247.71 ms | 1239.18 ms | -8.53 ms |
| 690220d+dirty | 1227.45 ms | 1221.67 ms | -5.78 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5bc97b+dirty | 2.92 MiB | 3.66 MiB | 758.40 KiB |
| 205982c+dirty | 2.92 MiB | 3.67 MiB | 772.63 KiB |
| 57448c5+dirty | 2.92 MiB | 3.66 MiB | 756.65 KiB |
| b1e8712+dirty | 2.92 MiB | 3.40 MiB | 494.15 KiB |
| 946a600+dirty | 2.92 MiB | 3.67 MiB | 772.40 KiB |
| b8ff156+dirty | 2.92 MiB | 3.67 MiB | 772.38 KiB |
| 0ebca77+dirty | 2.92 MiB | 3.61 MiB | 705.12 KiB |
| 9385d74+dirty | 2.92 MiB | 3.67 MiB | 772.40 KiB |
| 9dabcce+dirty | 2.92 MiB | 3.67 MiB | 770.02 KiB |
| 690220d+dirty | 2.92 MiB | 3.66 MiB | 758.77 KiB |
krystofwoldrich
approved these changes
Jan 10, 2025
Contributor
krystofwoldrich
left a comment
There was a problem hiding this comment.
LGTM 🚀 Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes RNSentryAndroidTester compatibility with AS Ladybug
💡 Motivation and Context
The Android tests weren't running on Android Studio LadyBug
💚 How did you test it?
CI, Manual testing
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog