Merged
Conversation
d561d19 to
c27ed78
Compare
Contributor
Author
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 700cbf4 | 425.56 ms | 436.26 ms | 10.70 ms |
| d0bf494+dirty | 375.37 ms | 395.14 ms | 19.77 ms |
| 575f9da | 415.26 ms | 422.98 ms | 7.72 ms |
| 9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
| 0ebca77 | 414.93 ms | 444.49 ms | 29.56 ms |
| e5c9b8b | 409.02 ms | 426.66 ms | 17.64 ms |
| db44eaf | 437.65 ms | 436.06 ms | -1.59 ms |
| c639edf | 466.48 ms | 489.57 ms | 23.09 ms |
| e1ea4a8 | 506.82 ms | 510.48 ms | 3.66 ms |
| 8de2810 | 430.47 ms | 428.72 ms | -1.75 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 700cbf4 | 17.73 MiB | 20.07 MiB | 2.33 MiB |
| d0bf494+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 575f9da | 17.73 MiB | 19.83 MiB | 2.10 MiB |
| 9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| 0ebca77 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
| e5c9b8b | 17.73 MiB | 19.83 MiB | 2.10 MiB |
| db44eaf | 17.74 MiB | 20.08 MiB | 2.35 MiB |
| c639edf | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| e1ea4a8 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 8de2810 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
Previous results on branch: deps/scripts/update-cli.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bceb209 | 444.15 ms | 448.08 ms | 3.93 ms |
| ab007ed | 481.36 ms | 463.73 ms | -17.63 ms |
| f653d25 | 458.56 ms | 466.06 ms | 7.51 ms |
| 6aace99 | 474.28 ms | 478.55 ms | 4.27 ms |
| 9a6d93f | 474.94 ms | 469.08 ms | -5.86 ms |
| 3ede92b | 420.67 ms | 456.76 ms | 36.09 ms |
| 50e79c9 | 412.64 ms | 422.65 ms | 10.01 ms |
| 3f68ac7 | 406.08 ms | 436.85 ms | 30.77 ms |
| d0b8a2e | 496.91 ms | 578.93 ms | 82.02 ms |
| 7806a23 | 444.12 ms | 433.18 ms | -10.95 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bceb209 | 17.73 MiB | 20.06 MiB | 2.33 MiB |
| ab007ed | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| f653d25 | 17.73 MiB | 20.07 MiB | 2.33 MiB |
| 6aace99 | 17.73 MiB | 20.07 MiB | 2.33 MiB |
| 9a6d93f | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 3ede92b | 17.73 MiB | 19.95 MiB | 2.21 MiB |
| 50e79c9 | 17.73 MiB | 19.94 MiB | 2.21 MiB |
| 3f68ac7 | 17.73 MiB | 19.94 MiB | 2.21 MiB |
| d0b8a2e | 17.73 MiB | 20.07 MiB | 2.33 MiB |
| 7806a23 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
antonis
approved these changes
Jan 3, 2025
Contributor
antonis
left a comment
There was a problem hiding this comment.
LGTM 🎉
Restraining from merging till this CI fix is merged and the checks are 🟢
c27ed78 to
8b41dbb
Compare
Contributor
Author
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9cd0e9f+dirty | 383.65 ms | 418.65 ms | 35.00 ms |
| 0db0c72+dirty | 335.20 ms | 351.06 ms | 15.86 ms |
| 8e80789+dirty | 464.48 ms | 551.10 ms | 86.63 ms |
| d2c32bb+dirty | 445.45 ms | 497.85 ms | 52.41 ms |
| c6f01ea+dirty | 379.95 ms | 439.35 ms | 59.40 ms |
| 690220d+dirty | 492.10 ms | 473.88 ms | -18.23 ms |
| 43e66e0+dirty | 378.20 ms | 404.59 ms | 26.40 ms |
| 77680ec+dirty | 393.50 ms | 426.68 ms | 33.18 ms |
| c398f67+dirty | 315.08 ms | 345.60 ms | 30.52 ms |
| 9433f35+dirty | 265.50 ms | 336.08 ms | 70.58 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9cd0e9f+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 0db0c72+dirty | 7.15 MiB | 8.04 MiB | 911.02 KiB |
| 8e80789+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| d2c32bb+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| c6f01ea+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 690220d+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
| 43e66e0+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 77680ec+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| c398f67+dirty | 7.15 MiB | 8.21 MiB | 1.07 MiB |
| 9433f35+dirty | 7.15 MiB | 8.08 MiB | 959.34 KiB |
Previous results on branch: deps/scripts/update-cli.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 760b447+dirty | 383.54 ms | 413.30 ms | 29.76 ms |
| 9a6d93f+dirty | 401.85 ms | 447.96 ms | 46.11 ms |
| 6aace99+dirty | 438.09 ms | 498.11 ms | 60.02 ms |
| bf2e12e+dirty | 417.46 ms | 471.48 ms | 54.02 ms |
| 7806a23+dirty | 387.04 ms | 432.29 ms | 45.24 ms |
| ab007ed+dirty | 439.69 ms | 494.25 ms | 54.56 ms |
| 6545c21+dirty | 418.70 ms | 440.36 ms | 21.65 ms |
| 546a3cd+dirty | 395.61 ms | 447.46 ms | 51.85 ms |
| 50e79c9+dirty | 339.27 ms | 369.08 ms | 29.81 ms |
| 7ce4c8d+dirty | 369.89 ms | 427.96 ms | 58.07 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 760b447+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 9a6d93f+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 6aace99+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| bf2e12e+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
| 7806a23+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| ab007ed+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 6545c21+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 546a3cd+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 50e79c9+dirty | 7.15 MiB | 8.22 MiB | 1.07 MiB |
| 7ce4c8d+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
Contributor
Author
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 575f9da+dirty | 1266.22 ms | 1274.84 ms | 8.62 ms |
| 57448c5+dirty | 1228.73 ms | 1235.90 ms | 7.16 ms |
| 6c56eb1+dirty | 1224.29 ms | 1232.00 ms | 7.71 ms |
| 8900e1a+dirty | 1210.27 ms | 1218.66 ms | 8.39 ms |
| acadc0f+dirty | 1264.38 ms | 1290.06 ms | 25.68 ms |
| 9a3ca65+dirty | 1247.06 ms | 1274.58 ms | 27.52 ms |
| 52c0562+dirty | 1219.34 ms | 1221.25 ms | 1.91 ms |
| e73d82f+dirty | 1207.52 ms | 1216.73 ms | 9.21 ms |
| 1332acb+dirty | 1230.53 ms | 1234.54 ms | 4.01 ms |
| 457e29f+dirty | 1253.94 ms | 1269.18 ms | 15.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 575f9da+dirty | 2.36 MiB | 2.87 MiB | 520.20 KiB |
| 57448c5+dirty | 2.36 MiB | 3.10 MiB | 752.34 KiB |
| 6c56eb1+dirty | 2.36 MiB | 3.11 MiB | 759.87 KiB |
| 8900e1a+dirty | 2.36 MiB | 2.83 MiB | 479.25 KiB |
| acadc0f+dirty | 2.36 MiB | 2.83 MiB | 480.37 KiB |
| 9a3ca65+dirty | 2.36 MiB | 2.82 MiB | 462.89 KiB |
| 52c0562+dirty | 2.36 MiB | 3.14 MiB | 793.36 KiB |
| e73d82f+dirty | 2.36 MiB | 3.08 MiB | 734.23 KiB |
| 1332acb+dirty | 2.36 MiB | 3.11 MiB | 759.86 KiB |
| 457e29f+dirty | 2.36 MiB | 2.87 MiB | 520.67 KiB |
Previous results on branch: deps/scripts/update-cli.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7806a23+dirty | 1233.90 ms | 1233.20 ms | -0.69 ms |
| f653d25+dirty | 1225.55 ms | 1227.48 ms | 1.93 ms |
| 50e79c9+dirty | 1229.49 ms | 1238.69 ms | 9.20 ms |
| 6545c21+dirty | 1234.39 ms | 1236.43 ms | 2.04 ms |
| ab007ed+dirty | 1221.67 ms | 1228.69 ms | 7.01 ms |
| 760b447+dirty | 1234.51 ms | 1236.90 ms | 2.39 ms |
| 3f68ac7+dirty | 1217.81 ms | 1219.67 ms | 1.87 ms |
| 9a6d93f+dirty | 1222.22 ms | 1224.09 ms | 1.86 ms |
| bf2e12e+dirty | 1220.51 ms | 1224.58 ms | 4.07 ms |
| bceb209+dirty | 1229.96 ms | 1222.64 ms | -7.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7806a23+dirty | 2.36 MiB | 3.11 MiB | 759.83 KiB |
| f653d25+dirty | 2.36 MiB | 3.08 MiB | 734.23 KiB |
| 50e79c9+dirty | 2.36 MiB | 3.04 MiB | 698.22 KiB |
| 6545c21+dirty | 2.36 MiB | 3.13 MiB | 784.66 KiB |
| ab007ed+dirty | 2.36 MiB | 3.08 MiB | 736.76 KiB |
| 760b447+dirty | 2.36 MiB | 3.11 MiB | 759.81 KiB |
| 3f68ac7+dirty | 2.36 MiB | 3.04 MiB | 696.33 KiB |
| 9a6d93f+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| bf2e12e+dirty | 2.36 MiB | 3.10 MiB | 757.79 KiB |
| bceb209+dirty | 2.36 MiB | 3.08 MiB | 731.94 KiB |
8b41dbb to
67da422
Compare
Contributor
Author
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 575f9da+dirty | 1272.00 ms | 1284.38 ms | 12.38 ms |
| 57448c5+dirty | 1244.65 ms | 1249.20 ms | 4.55 ms |
| 6c56eb1+dirty | 1240.96 ms | 1243.41 ms | 2.45 ms |
| 8900e1a+dirty | 1268.36 ms | 1273.04 ms | 4.68 ms |
| acadc0f+dirty | 1271.12 ms | 1272.28 ms | 1.16 ms |
| 9a3ca65+dirty | 1276.40 ms | 1279.14 ms | 2.74 ms |
| 52c0562+dirty | 1233.94 ms | 1226.29 ms | -7.65 ms |
| e73d82f+dirty | 1231.20 ms | 1228.81 ms | -2.40 ms |
| 1332acb+dirty | 1243.98 ms | 1241.12 ms | -2.86 ms |
| 457e29f+dirty | 1256.71 ms | 1258.50 ms | 1.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 575f9da+dirty | 2.92 MiB | 3.43 MiB | 524.26 KiB |
| 57448c5+dirty | 2.92 MiB | 3.66 MiB | 756.65 KiB |
| 6c56eb1+dirty | 2.92 MiB | 3.67 MiB | 772.48 KiB |
| 8900e1a+dirty | 2.92 MiB | 3.39 MiB | 485.96 KiB |
| acadc0f+dirty | 2.92 MiB | 3.39 MiB | 487.34 KiB |
| 9a3ca65+dirty | 2.92 MiB | 3.37 MiB | 464.32 KiB |
| 52c0562+dirty | 2.92 MiB | 3.69 MiB | 794.15 KiB |
| e73d82f+dirty | 2.92 MiB | 3.64 MiB | 740.56 KiB |
| 1332acb+dirty | 2.92 MiB | 3.67 MiB | 772.45 KiB |
| 457e29f+dirty | 2.92 MiB | 3.43 MiB | 524.75 KiB |
Previous results on branch: deps/scripts/update-cli.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7806a23+dirty | 1239.35 ms | 1242.81 ms | 3.46 ms |
| f653d25+dirty | 1245.67 ms | 1243.62 ms | -2.06 ms |
| 50e79c9+dirty | 1225.76 ms | 1217.82 ms | -7.93 ms |
| 6545c21+dirty | 1239.45 ms | 1245.35 ms | 5.90 ms |
| ab007ed+dirty | 1230.73 ms | 1230.08 ms | -0.65 ms |
| 760b447+dirty | 1236.53 ms | 1233.92 ms | -2.61 ms |
| 3f68ac7+dirty | 1223.18 ms | 1229.84 ms | 6.65 ms |
| 9a6d93f+dirty | 1227.73 ms | 1242.12 ms | 14.39 ms |
| bf2e12e+dirty | 1239.47 ms | 1227.89 ms | -11.58 ms |
| bceb209+dirty | 1230.39 ms | 1237.37 ms | 6.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7806a23+dirty | 2.92 MiB | 3.67 MiB | 772.43 KiB |
| f653d25+dirty | 2.92 MiB | 3.64 MiB | 740.61 KiB |
| 50e79c9+dirty | 2.92 MiB | 3.61 MiB | 705.06 KiB |
| 6545c21+dirty | 2.92 MiB | 3.69 MiB | 791.07 KiB |
| ab007ed+dirty | 2.92 MiB | 3.64 MiB | 742.56 KiB |
| 760b447+dirty | 2.92 MiB | 3.67 MiB | 772.35 KiB |
| 3f68ac7+dirty | 2.92 MiB | 3.60 MiB | 701.92 KiB |
| 9a6d93f+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| bf2e12e+dirty | 2.92 MiB | 3.66 MiB | 763.03 KiB |
| bceb209+dirty | 2.92 MiB | 3.64 MiB | 738.52 KiB |
67da422 to
e7f30aa
Compare
This was referenced Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-cli.sh from 2.39.1 to 2.40.0.
Auto-generated by a dependency updater.
Changelog
2.40.0
New features
globalThiswhen available (#2301) by lforstImprovements
Bug fixes
Non-user-facing changes
We made several refactors and added several tests in this release. These changes should not affect users.
upload-difreference frompoll_assemble(#2321) by szokeasaurusrexrender_detailtakeOption<&str>(#2317) by szokeasaurusrexupload_difs_chunked(#2316) by szokeasaurusrexuploadmodule tooptions(#2315) by szokeasaurusrexChunkOptionsastruct(#2314) by szokeasaurusrex&strinDifUploadstruct (#2307) by szokeasaurusrexpoll_assemble(#2300) by szokeasaurusrex/to uploaded Proguard file name (#2304) by szokeasaurusrextry_assembleoptionsparameter (#2299) by szokeasaurusrexChunkedUploadOptionsto indicate they are set by server (#2298) by szokeasaurusrexChunked<ProguardMapping>for proguard upload (#2296) by szokeasaurusrexChunkedDifRequesttakeCow<'_, str>forname(#2295) by szokeasaurusrexMappingRefwithProguardMapping(#2294) by szokeasaurusrexproguardutilssubmodule (#2293) by szokeasaurusrexByteView(#2292) by szokeasaurusrexChunkedDifRequest(#2290) by szokeasaurusrexNamedtrait toAssemblable(#2289) by szokeasaurusrexpoll_assemblegeneric (#2287) by szokeasaurusrexToAssembletraittry_assemble_difgenericChunkedDifMatchwith genericChunkedObjectusizeinget_sha1_checksumssignatureassert_cmdtest manager