Skip to content

fix(react-navigation): Make navigation.processing span title more explicit #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krystofwoldrich merged 5 commits into from
Jan 8, 2025
Merged

fix(react-navigation): Make navigation.processing span title more explicit #4423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eaa31d3
fix(react-navigation): Make `navigation.processing` span title more e…
Jan 8, 2025
9ec98a9
Also update updated name after screen name is known
Jan 8, 2025
02120b6
add `screen` before the actual name
Jan 8, 2025
bc87ac1
fix tests
Jan 8, 2025
d26b8a3
Merge branch 'main' into kw-fix-navigation-processing-span-name
krystofwoldrich Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

## Unreleased

### Changes

- Rename `navigation.processing` span to more expressive `Navigation dispatch to screen A mounted/navigation cancelled` ([#4423](https://github.com/getsentry/sentry-react-native/pull/4423))

### Dependencies

- Bump CLI from v2.39.1 to v2.40.0 ([#4412](https://github.com/getsentry/sentry-react-native/pull/4412))
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/js/tracing/reactnavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export const reactNavigationIntegration = ({
if (enableTimeToInitialDisplay) {
navigationProcessingSpan = startInactiveSpan({
op: 'navigation.processing',
name: 'Navigation processing',
name: 'Navigation dispatch to navigation cancelled or screen mounted',
startTime: latestNavigationSpan && spanToJSON(latestNavigationSpan).start_timestamp,
});
navigationProcessingSpan.setAttribute(
Expand Down Expand Up @@ -274,7 +274,7 @@ export const reactNavigationIntegration = ({
});
}

navigationProcessingSpan?.updateName(`Processing navigation to ${route.name}`);
navigationProcessingSpan?.updateName(`Navigation dispatch to screen ${route.name} mounted`);
navigationProcessingSpan?.setStatus({ code: SPAN_STATUS_OK });
navigationProcessingSpan?.end(stateChangedTimestamp);
navigationProcessingSpan = undefined;
Expand Down
4 changes: 2 additions & 2 deletions packages/core/test/tracing/reactnavigation.ttid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ describe('React Navigation - TTID', () => {
'sentry.origin': SPAN_ORIGIN_AUTO_NAVIGATION_REACT_NAVIGATION,
'sentry.source': 'custom',
},
description: 'Processing navigation to New Screen',
description: 'Navigation dispatch to screen New Screen mounted',
op: 'navigation.processing',
origin: SPAN_ORIGIN_AUTO_NAVIGATION_REACT_NAVIGATION,
status: 'ok',
Expand Down Expand Up @@ -232,7 +232,7 @@ describe('React Navigation - TTID', () => {
'sentry.origin': SPAN_ORIGIN_AUTO_NAVIGATION_REACT_NAVIGATION,
'sentry.source': 'custom',
},
description: 'Processing navigation to Initial Screen',
description: 'Navigation dispatch to screen Initial Screen mounted',
op: 'navigation.processing',
origin: SPAN_ORIGIN_AUTO_NAVIGATION_REACT_NAVIGATION,
status: 'ok',
Expand Down
Loading