Skip to content

Fix sdk name for replay tags #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 2 commits into from
Jan 9, 2025
Merged

Fix sdk name for replay tags #4428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e75572
Fix sdk name for replay tags
romtsn Jan 8, 2025
0466853
Changelog
romtsn Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

## Unreleased

### Fixes

- Use proper SDK name for Session Replay tags ([#4428](https://github.com/getsentry/sentry-react-native/pull/4428))

### Changes

- Rename `navigation.processing` span to more expressive `Navigation dispatch to screen A mounted/navigation cancelled` ([#4423](https://github.com/getsentry/sentry-react-native/pull/4423))
Expand Down
2 changes: 1 addition & 1 deletion packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ private boolean isReplayEnabled(SentryReplayOptions replayOptions) {
private SentryReplayOptions getReplayOptions(@NotNull ReadableMap rnOptions) {
final SdkVersion replaySdkVersion =
new SdkVersion(
RNSentryVersion.REACT_NATIVE_SDK_PACKAGE_NAME,
RNSentryVersion.REACT_NATIVE_SDK_NAME,
RNSentryVersion.REACT_NATIVE_SDK_PACKAGE_VERSION);
@NotNull
final SentryReplayOptions androidReplayOptions =
Expand Down
1 change: 1 addition & 0 deletions packages/core/android/src/main/java/io/sentry/react/RNSentryVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ class RNSentryVersion {
static final String REACT_NATIVE_SDK_PACKAGE_VERSION = "6.5.0";
static final String NATIVE_SDK_NAME = "sentry.native.android.react-native";
static final String ANDROID_SDK_NAME = "sentry.java.android.react-native";
static final String REACT_NATIVE_SDK_NAME = "sentry.javascript.react-native";
}
Loading