Skip to content

chore: Remove deprecated user property #5291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 1 commit into from
Oct 22, 2025
Merged

chore: Remove deprecated user property #5291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryUserTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ - (void)testValidUser
[expected setIpAddress:@"192.168.1.1"];
[expected setEmail:@"test@example.com"];
[expected setUsername:@"testuser"];
[expected setSegment:@"testsegment"];
[expected setData:@{
@"foo" : @"bar",
@"baz" : @123,
Expand All @@ -26,7 +25,6 @@ - (void)testValidUser
@"ip_address" : @"192.168.1.1",
@"email" : @"test@example.com",
@"username" : @"testuser",
@"segment" : @"testsegment",
}
otherUserKeys:@{
@"foo" : @"bar",
Expand Down Expand Up @@ -67,7 +65,6 @@ - (void)testInvalidUser
@"ip_address" : @ {},
@"email" : @ {},
@"username" : @ {},
@"segment" : @[],
}
otherUserKeys:nil];

Expand All @@ -84,7 +81,6 @@ - (void)testPartiallyInvalidUser
@"ip_address" : @ {},
@"email" : @ {},
@"username" : @ {},
@"segment" : @[],
}
otherUserKeys:nil];

Expand All @@ -100,7 +96,6 @@ - (void)testNullValuesUser
@"ip_address" : [NSNull null],
@"email" : [NSNull null],
@"username" : [NSNull null],
@"segment" : [NSNull null],
}
otherUserKeys:nil];

Expand Down
4 changes: 0 additions & 4 deletions packages/core/ios/RNSentry.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,10 +723,6 @@ + (SentryUser *_Nullable)userFrom:(NSDictionary *)userKeys
if ([username isKindOfClass:NSString.class]) {
[userInstance setUsername:username];
}
id segment = [userKeys valueForKey:@"segment"];
if ([segment isKindOfClass:NSString.class]) {
[userInstance setSegment:segment];
}

if ([userDataKeys isKindOfClass:NSDictionary.class]) {
[userInstance setData:userDataKeys];
Expand Down
Loading