feat(metrics): Updates Metrics code to correctly process envelops with`application/vnd.sentry.items.trace-metric+json` content type by alwx · Pull Request #5440 · getsentry/sentry-react-native

alwx · 2025-12-04T15:18:16Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Updates metrics to be processed correctly.
In addition to that, updates some of the tests that were incorrectly using content type for logs.

💚 How did you test it?

Tests, tests, tests. And just running the app and seing myself.

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2025-12-04T15:18:52Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a44e8fb

packages/core/test/wrapper.test.ts

antonis

Awesome @alwx 🚀
I've retested with the sample app and was able to see metrics on the dashboard :)

Added a comment on a linter issue but other than that LGTM.
Let's also investigate @lucas-zimerman comment before merging 🙇

lucas-zimerman · 2025-12-05T13:31:56Z

@sentry review

packages/core/src/js/wrapper.ts

        bytesPayload = itemPayload;
      } else {
-        bytesContentType = 'application/vnd.sentry.items.log+json';
+        bytesContentType = typeof itemHeader.content_type === 'string' ? itemHeader.content_type : 'application/json';


samples/react-native/src/Screens/ErrorsScreen.tsx

lucas-zimerman

Thank you for the PR! once we fix the linting/build issues, we could merge the PR :D

github-actions · 2025-12-05T13:53:50Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	478.65 ms	474.69 ms	-3.96 ms
Size	43.75 MiB	48.07 MiB	4.32 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d1bfbde`+dirty	478.88 ms	505.52 ms	26.64 ms
`93137d1`+dirty	400.15 ms	424.74 ms	24.59 ms
`05bef0e`+dirty	349.78 ms	334.04 ms	-15.74 ms
`77061ed`+dirty	369.55 ms	408.35 ms	38.80 ms
`a941c72`+dirty	489.85 ms	549.17 ms	59.32 ms
`6479fd5`+dirty	412.95 ms	434.02 ms	21.07 ms
`07808fb`+dirty	419.10 ms	419.08 ms	-0.02 ms
`b80b14f`+dirty	505.06 ms	534.32 ms	29.26 ms
`90afdd3`+dirty	375.94 ms	377.52 ms	1.58 ms
`5526494`	440.84 ms	448.36 ms	7.52 ms

App size

Revision	Plain	With Sentry	Diff
`d1bfbde`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`93137d1`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`05bef0e`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`77061ed`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`a941c72`+dirty	43.75 MiB	48.05 MiB	4.29 MiB
`6479fd5`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`07808fb`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`b80b14f`+dirty	43.75 MiB	48.04 MiB	4.29 MiB
`90afdd3`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`5526494`	17.75 MiB	19.68 MiB	1.93 MiB

github-actions · 2025-12-05T13:55:02Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	432.85 ms	474.56 ms	41.71 ms
Size	43.94 MiB	48.90 MiB	4.96 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`88890fe`+dirty	328.30 ms	319.85 ms	-8.45 ms
`c1573b3`+dirty	355.65 ms	448.82 ms	93.17 ms
`2104bb9`+dirty	313.00 ms	309.76 ms	-3.24 ms
`1d62dde`+dirty	366.59 ms	408.80 ms	42.21 ms
`8a4ce6f`+dirty	401.11 ms	381.92 ms	-19.19 ms
`c4e097a`+dirty	382.43 ms	443.77 ms	61.34 ms
`46da307`+dirty	356.62 ms	415.02 ms	58.40 ms
`8e653ac`+dirty	304.49 ms	308.84 ms	4.35 ms
`e2fa43d`+dirty	326.56 ms	372.88 ms	46.32 ms
`07808fb`+dirty	392.47 ms	451.94 ms	59.47 ms

App size

Revision	Plain	With Sentry	Diff
`88890fe`+dirty	7.15 MiB	8.44 MiB	1.28 MiB
`c1573b3`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`2104bb9`+dirty	7.15 MiB	8.46 MiB	1.30 MiB
`1d62dde`+dirty	7.15 MiB	8.46 MiB	1.31 MiB
`8a4ce6f`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`c4e097a`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`46da307`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`8e653ac`+dirty	7.15 MiB	8.46 MiB	1.31 MiB
`e2fa43d`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`07808fb`+dirty	7.15 MiB	8.43 MiB	1.28 MiB

alwx · 2025-12-05T13:57:21Z

@lucas-zimerman that's done now

github-actions · 2025-12-05T14:21:34Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1210.57 ms	1220.53 ms	9.96 ms
Size	3.41 MiB	4.67 MiB	1.25 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`083f560`+dirty	1215.27 ms	1231.96 ms	16.69 ms
`f3b058c`+dirty	1221.43 ms	1219.85 ms	-1.58 ms
`23080e5`+dirty	1221.39 ms	1222.08 ms	0.70 ms
`534ba8c`+dirty	1225.00 ms	1237.43 ms	12.43 ms
`493c1a1`+dirty	1220.50 ms	1221.30 ms	0.80 ms
`6416d6c`+dirty	1222.83 ms	1222.04 ms	-0.79 ms
`46da307`+dirty	1213.45 ms	1207.96 ms	-5.49 ms
`e07935d`+dirty	1225.85 ms	1227.72 ms	1.87 ms
`ec14be7`+dirty	1229.62 ms	1230.53 ms	0.91 ms
`90afdd3`+dirty	1216.17 ms	1225.55 ms	9.38 ms

App size

Revision	Plain	With Sentry	Diff
`083f560`+dirty	3.19 MiB	4.56 MiB	1.38 MiB
`f3b058c`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`23080e5`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`534ba8c`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`493c1a1`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`6416d6c`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`46da307`+dirty	3.19 MiB	4.44 MiB	1.25 MiB
`e07935d`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`ec14be7`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`90afdd3`+dirty	3.19 MiB	4.55 MiB	1.37 MiB

github-actions · 2025-12-05T14:23:59Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1222.38 ms	1221.00 ms	-1.38 ms
Size	3.41 MiB	4.67 MiB	1.25 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`083f560`+dirty	1227.33 ms	1242.02 ms	14.69 ms
`f3b058c`+dirty	1221.30 ms	1214.62 ms	-6.68 ms
`23080e5`+dirty	1216.02 ms	1224.94 ms	8.91 ms
`534ba8c`+dirty	1230.22 ms	1231.18 ms	0.96 ms
`493c1a1`+dirty	1207.58 ms	1211.80 ms	4.22 ms
`6416d6c`+dirty	1220.38 ms	1222.98 ms	2.60 ms
`46da307`+dirty	1217.08 ms	1224.16 ms	7.08 ms
`e07935d`+dirty	1217.37 ms	1211.44 ms	-5.93 ms
`ec14be7`+dirty	1234.64 ms	1245.54 ms	10.90 ms
`90afdd3`+dirty	1233.90 ms	1240.90 ms	7.00 ms

App size

Revision	Plain	With Sentry	Diff
`083f560`+dirty	2.63 MiB	4.00 MiB	1.36 MiB
`f3b058c`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`23080e5`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`534ba8c`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`493c1a1`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`6416d6c`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`46da307`+dirty	2.63 MiB	3.87 MiB	1.24 MiB
`e07935d`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`ec14be7`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`90afdd3`+dirty	2.63 MiB	3.99 MiB	1.35 MiB

lucas-zimerman

LGTM!

lucas-zimerman

Leaving as request changes for a second check.

@antonis @alwx, Could you double-check that metrics are being sent on Android? I have tried this branch today on an Android simulator, and despite seeing it on spotlightJs, I don't see it on sentry.io (I was able to see if I disabled the native integration)

EDIT: If you don't see it on Android, we may need to alter the Java SDK because it's overwriting the envelope type to unknown

alwx · 2025-12-09T12:12:12Z

@lucas-zimerman you seem to be correct — the enabled native integration kills it. But as I understood, it seems to be related to unknown spans on Android, which means it requires no changes to RN code and this PR in particular, right?

antonis · 2025-12-09T12:25:32Z

@lucas-zimerman you seem to be correct — the enabled native integration kills it. But as I understood, it seems to be related to unknown spans on Android, which means it requires no changes to RN code and this PR in particular, right?

@alwx I think this is the case 👍 Maybe we can update the changelog in this (or a separate PR) clarifying that the metrics are released in beta only for iOS and merge/release this fix.
We can then add a changelog for the Android beta release of metrics when we merge the Android SDK bump that includes the fix. Wdyt?

alwx · 2025-12-09T12:34:16Z

@antonis makes sense, I'd do that. @lucas-zimerman what do you think?

lucas-zimerman · 2025-12-09T12:40:19Z

I also agree.
A PR to fix this is on the way, but I have no idea when it will be released: getsentry/sentry-java#4956

EDIT: There is no additional changes required on this PR, should we wait for the Android update so both iOS/Android have support for Metrics, or release this PR mentioning that it's only supported on iOS?

antonis · 2025-12-09T12:46:18Z

release this PR mentioning that it's only supported on iOS?

Since it is a beta release I think it would be ok to release only on iOS. I'll leave that up to @alwx 🙇

antonis

LGTM 🚀

alwx · 2025-12-09T12:55:55Z

@lucas-zimerman @antonis I've updated the changelog entry with information that it only works on iOS.

lucas-zimerman

LGTM!

feat(metrics): A fix for metrics

8386d96

alwx changed the title ~~feat(metrics): Updates Metrics code to make them being processed correctly~~ feat(metrics): Updates Metrics code to make Metrics being processed correctly Dec 4, 2025

Updated tests

b1b8c32

alwx changed the title ~~feat(metrics): Updates Metrics code to make Metrics being processed correctly~~ feat(metrics): Updates Metrics code to correctly process envelops withapplication/vnd.sentry.items.trace-metric+json content type Dec 5, 2025

alwx marked this pull request as ready for review December 5, 2025 09:09

alwx requested review from antonis and lucas-zimerman as code owners December 5, 2025 09:09

lucas-zimerman reviewed Dec 5, 2025

View reviewed changes

packages/core/test/wrapper.test.ts Outdated Show resolved Hide resolved

Merge branch 'main' into alwx/bugfix/metrics-fix

8bec235

antonis reviewed Dec 5, 2025

View reviewed changes

packages/core/test/wrapper.test.ts Outdated Show resolved Hide resolved

antonis reviewed Dec 5, 2025

View reviewed changes

Fixes

4de2525

alwx requested review from antonis and lucas-zimerman December 5, 2025 12:30

sentry bot reviewed Dec 5, 2025

View reviewed changes

lucas-zimerman added the ready-to-merge Triggers the full CI test suite label Dec 5, 2025

lucas-zimerman reviewed Dec 5, 2025

View reviewed changes

lucas-zimerman mentioned this pull request Dec 5, 2025

V3: Updates Metrics code to correctly process envelops withapplication/vnd.sentry.items.trace-metric+json content type getsentry/sentry-capacitor#1050

Closed

Lint fiix

3552040

alwx requested a review from lucas-zimerman December 5, 2025 13:57

Merge branch 'main' into alwx/bugfix/metrics-fix

e0cac1d

lucas-zimerman approved these changes Dec 8, 2025

View reviewed changes

lucas-zimerman requested changes Dec 8, 2025

View reviewed changes

alwx self-assigned this Dec 9, 2025

Merge branch 'main' into alwx/bugfix/metrics-fix

87a5fcc

antonis approved these changes Dec 9, 2025

View reviewed changes

antonis and others added 2 commits December 9, 2025 13:47

Merge branch 'main' into alwx/bugfix/metrics-fix

c7e5639

Wording fix

a44e8fb

alwx requested a review from lucas-zimerman December 9, 2025 12:54

alwx enabled auto-merge (squash) December 9, 2025 13:10

lucas-zimerman approved these changes Dec 9, 2025

View reviewed changes

alwx merged commit ad27f6e into main Dec 9, 2025
73 of 74 checks passed

alwx deleted the alwx/bugfix/metrics-fix branch December 9, 2025 13:13

Uh oh!

Conversation

alwx commented Dec 4, 2025 • edited by lucas-zimerman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman commented Dec 5, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

alwx commented Dec 5, 2025

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alwx commented Dec 9, 2025

Uh oh!

antonis commented Dec 9, 2025

Uh oh!

alwx commented Dec 9, 2025

Uh oh!

lucas-zimerman commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonis commented Dec 9, 2025

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

alwx commented Dec 9, 2025

Uh oh!

lucas-zimerman left a comment

alwx commented Dec 4, 2025 •

edited by lucas-zimerman

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

lucas-zimerman left a comment •

edited

Loading

lucas-zimerman commented Dec 9, 2025 •

edited

Loading