Skip to content

Revert "ref(gocd): update gocd script to use console script entry point"#237

Merged
bruno-garcia merged 1 commit intomainfrom
revert-235-mingchen/di-1026-migrate-all-scripts-to-use-console-scripts
Jul 12, 2025
Merged

Revert "ref(gocd): update gocd script to use console script entry point"#237
bruno-garcia merged 1 commit intomainfrom
revert-235-mingchen/di-1026-migrate-all-scripts-to-use-console-scripts

Conversation

@bruno-garcia
Copy link
Member

Reverts #235

Fails with:

3623d90b-114e-478f-a6a1-9308cd13310a.sh: line 2: checks-googlecloud-check-cloudbuild: command not found

https://deploy.getsentry.net/go/tab/build/detail/deploy-symbol-collector/30/checks/1/checks

@bruno-garcia bruno-garcia merged commit 74aeedc into main Jul 12, 2025
8 checks passed
@bruno-garcia bruno-garcia deleted the revert-235-mingchen/di-1026-migrate-all-scripts-to-use-console-scripts branch July 12, 2025 02:55
@codecov
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.07%. Comparing base (d3fd261) to head (75666e7).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   52.60%   51.07%   -1.53%     
==========================================
  Files          27       27              
  Lines        1346     1351       +5     
  Branches      105      105              
==========================================
- Hits          708      690      -18     
- Misses        603      625      +22     
- Partials       35       36       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mchen-sentry
Copy link
Member

Hey Bruno, sorry about this, I should have left a note in the PR that this change wasn't ready to be merged in yet.

While we've merged in the reference PR, it's only been deployed in staging and is not live in GoCD prod yet.

Apologies for any confusion and thanks for approving it. Will clean this up on Monday, cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants