Use Random.Shared instead of instantiating Random#243
Merged
bruno-garcia merged 1 commit intomainfrom Aug 28, 2025
Merged
Conversation
bruno-garcia
approved these changes
Aug 27, 2025
Member
|
Thanks Sentry, finally someone solves bugs from this code base 😅 |
Member
Verified Seer indeed fixed this issue btw! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SYMBOL-COLLECTOR-SERVER-BC. The issue was that: Concurrent
InMemorySymbolService.Storecalls generate identical temporary file paths due to non-thread-safeRandominstance, causing file access conflicts.This change replaces the instantiation of a new
Randomobject with the use ofRandom.Sharedto generate random numbers. This is more efficient as it avoids the overhead of creating a newRandomobject each time a random number is needed.This fix was generated by Seer in Sentry, triggered by bruno@sentry.io. 👁️ Run ID: 1049720
Not quite right? Click here to continue debugging with Seer.