Skip to content

Improve APK download and upload logic#245

Closed
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/improve-apk-download
Closed

Improve APK download and upload logic#245
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer/improve-apk-download

Conversation

@seer-by-sentry
Copy link
Contributor

Fixes ANDROID-SYMBOL-COLLECTOR-RUNNER-N. The issue was that: Session creation fails because the runner uses the unreliable storage:filename reference when the APK download is skipped.

  • Add a check to see if the APK file exists before skipping the download.
  • Throw an exception if the APK file is not found when skipUpload is false.

This fix was generated by Seer in Sentry, triggered by bruno@sentry.io. 👁️ Run ID: 2043653

Not quite right? Click here to continue debugging with Seer.

@bruno-garcia
Copy link
Member

This will have it throw if skipUpload isn't set but the invocation is done here

dotnet run --project src/SymbolCollector.Runner/SymbolCollector.Runner.csproj -c Release /p:TreatWarningsAsErrors=false

And we don't pass skipUpload. We could, although Seer missed doing that in this patch. But anyway that wouldn't be the correct fix because I need the file to be uploaded if a new one is downloaded by the powershell script that runs before the Runner.

@bruno-garcia bruno-garcia deleted the seer/improve-apk-download branch October 19, 2025 01:05
@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.37%. Comparing base (7b4e4d9) to head (d2859ec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   51.26%   52.37%   +1.11%     
==========================================
  Files          27       27              
  Lines        1348     1348              
  Branches      105      105              
==========================================
+ Hits          691      706      +15     
+ Misses        623      607      -16     
- Partials       34       35       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant