Conversation
In 363b1e7 (git: drop the commit hash from pkgver for MSYS2 compatibility, 2025-11-14), I dropped the auto-updating logic of `pkgver`, forgetting that Git for Windows' automation would not update that line. As a consequence, the Pacman packages built as part of Git for Windows' v2.53.0 release process incorrectly reference the previous pkgver and the Git for Windows SDKs do not enjoy the update. Let's fix that by switching to a Bash'ism (which is fine, given that `makepkg` contains _so many_ Bash'isms that it is highly implausible that it will ever work with any other Unix shell). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
I guess I should update |
By mistake, the Pacman packages generated as part of Git for Windows' v2.53.0 release process contain the previous version number, and are therefore not picked up by `pacman -Syu`. Let's just rebuild and deploy the package, but with an incremented pkgrel so that it is obvious why the executables contained in that package differ from the ones in the official Git for Windows release. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This comment was marked as outdated.
This comment was marked as outdated.
|
/deploy mingw-w64-git The i686/x86_64 and the arm64 workflow runs were started. |
|
Unfortunately, the deployment failed with "Failed: HTTP/1.1 413 The request body is too large and exceeds the maximum permissible limit." The reason for that is this line: https://github.com/git-for-windows/build-extra/blob/70e451a41639278c27933290ef7f874771993b45/wingit-snapshot-helper.sh#L137 This limits the API version we use to upload to Azure Blobs, which in turn limits the size of the package we can upload to <256MB. The I've fixed the deployment manually, using the fact that Azure Blobs allows larger uploads in the meantime (which I could have realized in 2023, seeing as API version 2019-12-12 allows larger uploads). So with that, this PR is good to be merged! |
2 participants
In 363b1e7 (git: drop the commit hash from pkgver for MSYS2 compatibility, 2025-11-14), I dropped the auto-updating logic of
pkgver, forgetting that Git for Windows' automation would not update that line. As a consequence, the Pacman packages built as part of Git for Windows' v2.53.0 release process incorrectly reference the previous pkgver and the Git for Windows SDKs do not enjoy the update.Let's fix that by switching to a Bash'ism (which is fine, given that
makepkgcontains so many Bash'isms that it is highly implausible that it will ever work with any other Unix shell).