Make reproducing webhook failures easier #190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When exceptions are thrown, the exit code should not be 0. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
It is often exceedingly tedious to reproduce webhook delivery failures, even though we now have a convenient script that finds the webhook corresponding to a failed slash command. Let's introduce an option (guarded by an environment variable) to log the exact `curl` call to reproduce the call that might have failed. This is guarded by default essentially for one reason: It also includes the authorization token, unredacted, which would be unsafe by default. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
make-reproducing-webhook-failures-easier
branch
from
f35ca58 to
289b3f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make debugging webhook failures slightly less tedious on the local side. I have not yet had a chance to actually use this, because I single stepped through the failed webhook deliveries of the past few days. My hope though is that it will come in handy in the future.
We do not actually have to merge this before the next incident, (which I suspect will come soon, anyway).