Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds initial support for the vcpkg ecosystem by introducing a new Dockerfile and wiring it into the container update flow.
- Register
vcpkgin the TypeScript manifest file for container images. - Add a new
vcpkgentry (with placeholder tag) tocontainers.json. - Create
Dockerfile.vcpkgwith a placeholderFROMimage.
Reviewed Changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/update-containers.ts | Include vcpkg in the manifest passed to write. |
| docker/containers.json | Add vcpkg key with a placeholder image tag. |
| docker/Dockerfile.vcpkg | New Dockerfile for vcpkg, currently using TODO. |
Comments suppressed due to low confidence (1)
src/update-containers.ts:47
- There’s no existing test for the new
vcpkgpath. Consider adding a unit or integration test to verify thatgetImageName('Dockerfile.vcpkg')returns the expected value.
vcpkg: getImageName('Dockerfile.vcpkg')
| "uv": "ghcr.io/dependabot/dependabot-updater-uv:v2.0.20250606230616@sha256:6edb61a20817fa6e1bdfda51173f8ad7323a91ab0ac72345384af2c23c6b5aff", | ||
| "helm": "ghcr.io/dependabot/dependabot-updater-helm:v2.0.20250606230616@sha256:a6eadb370b009a3e74c3dd08fb57b46c9f0d0de39ea032dcc49973d8bbd80436" | ||
| "helm": "ghcr.io/dependabot/dependabot-updater-helm:v2.0.20250606230616@sha256:a6eadb370b009a3e74c3dd08fb57b46c9f0d0de39ea032dcc49973d8bbd80436", | ||
| "vcpkg": "ghcr.io/dependabot/dependabot-updater-vcpkg:TODO" |
There was a problem hiding this comment.
The placeholder TODO in the image tag will cause lookup failures. Please replace it with the actual version and SHA, matching your release process.
| "vcpkg": "ghcr.io/dependabot/dependabot-updater-vcpkg:TODO" | |
| "vcpkg": "ghcr.io/dependabot/dependabot-updater-vcpkg:v2.0.20250606230616@sha256:1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef" |
| @@ -0,0 +1 @@ | |||
| FROM ghcr.io/dependabot/dependabot-updater-vcpkg:TODO | |||
There was a problem hiding this comment.
The base image reference uses TODO as a tag. Update this to the correct image version (and include a digest if required) to ensure the build succeeds.
| FROM ghcr.io/dependabot/dependabot-updater-vcpkg:TODO | |
| FROM ghcr.io/dependabot/dependabot-updater-vcpkg:1.2.3 |
| @@ -0,0 +1 @@ | |||
| FROM ghcr.io/dependabot/dependabot-updater-vcpkg:TODO | |||
There was a problem hiding this comment.
[nitpick] Consider adding a newline at the end of this Dockerfile to adhere to standard file formatting conventions.
fa97319 to
e1e0ad7
Compare
|
Closing in favour of #1509 |
NOTE: Cannot be merged until the PR in
dependabot-coreis merged first.Related:
vcpkgsupport dependabot/cli#462vcpkgsmoke tests dependabot/smoke-tests#300