-
Notifications
You must be signed in to change notification settings - Fork 6
fix: recompile lock files with release action mode #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR #526 accidentally compiled with dev action mode (`./actions/setup`) instead of release mode (`github/gh-aw/actions/setup@SHA`). This causes activation jobs to fail because the local actions/setup directory doesn't exist in the firewall repo. Recompile with --action-mode release --action-tag v0.42.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
✅ Coverage Check PassedOverall Coverage
Coverage comparison generated by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR recompiles all 23 workflow lock files to use release action mode with v0.42.0, fixing a critical issue from PR #526 where lock files were compiled in dev mode. The dev mode compilation used a local path reference ./actions/setup which doesn't exist in this repository, causing all activation jobs to fail with "Can't find 'action.yml' under 'actions/setup'" errors.
Changes:
- Replace all local action references (
./actions/setup) with pinned remote action references (github/gh-aw/actions/setup@a7134347103ecf66b4bd422c3e9ce6466d400c02) - Remove redundant "Checkout actions folder" steps that are no longer needed
- Update repository checkout steps to use sparse checkout for only
.githuband.agentsfolders
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| update-release-notes.lock.yml | Updated action references and checkout configuration |
| test-coverage-improver.lock.yml | Updated action references and checkout configuration |
| smoke-copilot.lock.yml | Updated action references, checkout configuration, and permissions |
| smoke-claude.lock.yml | Updated action references, checkout configuration, and permissions |
| smoke-chroot.lock.yml | Updated action references and checkout configuration |
| security-review.lock.yml | Updated action references, checkout configuration, and permissions |
| security-guard.lock.yml | Updated action references and checkout configuration |
| plan.lock.yml | Updated action references, checkout configuration, permissions, and removed GH_AW_IS_PR_COMMENT logic |
| pelis-agent-factory-advisor.lock.yml | Updated action references, checkout configuration, and permissions |
| issue-monster.lock.yml | Updated action references, checkout configuration, and permissions |
| issue-duplication-detector.lock.yml | Updated action references, checkout configuration, and permissions |
| doc-maintainer.lock.yml | Updated action references, checkout configuration, and permissions |
| dependency-security-monitor.lock.yml | Updated action references and checkout configuration |
| cli-flag-consistency-checker.lock.yml | Updated action references and checkout configuration |
| ci-doctor.lock.yml | Updated action references, checkout configuration, and permissions |
| ci-cd-gaps-assessment.lock.yml | Updated action references and checkout configuration |
| build-test-rust.lock.yml | Updated action references and checkout configuration |
| build-test-node.lock.yml | Updated action references and checkout configuration |
| build-test-java.lock.yml | Updated action references and checkout configuration |
| build-test-go.lock.yml | Updated action references and checkout configuration |
| build-test-deno.lock.yml | Updated action references and checkout configuration |
| build-test-cpp.lock.yml | Updated action references and checkout configuration |
| build-test-bun.lock.yml | Updated action references and checkout configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Smoke test results for run #21727792741:
Status: PASS 🎉 cc @Mossaka
|
C++ Build Test Results
Overall: PASS ✅ All C++ projects built successfully.
|
Build Test: Deno - PASS ✅All Deno tests passed successfully.
Overall: PASS ✅
|
Go Build Test Results
Overall: PASS ✅ All Go projects successfully downloaded dependencies and passed tests.
|
Build Test: Node.js - Results
Overall: PASS ✅ All Node.js projects built and tested successfully.
|
Build Test: Bun - FAILED ❌Test Results
Overall: FAIL ❌ Error DetailsBoth projects failed with the same error when running Root cause: Bun test runner crashed with a segmentation fault (core dump) in the container environment. This appears to be a compatibility issue between Bun v1.3.8 and the container runtime. Environment
Next StepsThis failure indicates that Bun's test runner is not compatible with the current container environment. Possible solutions:
|
Reverts the following PRs which introduced unnecessary complexity: - #520: fix: enable Squid intercept mode for NAT-redirected traffic - v0.13.5 release: chore(release): bump version to 0.13.5 - #524: fix: remove HTTP_PROXY/HTTPS_PROXY env vars from agent container - #526: chore: recompile workflow lock files for AWF v0.13.5 - #527: fix: recompile lock files with release action mode - #522: fix: mount /etc/hosts in chroot and fix HTTP blocking test - #530: fix: restore HTTPS_PROXY, fix chroot hosts/permissions, fix Bun crash - v0.13.6 release: chore(release): bump version to 0.13.6 The intercept mode (#520) was introduced to fix Codex failing with HTTP_PROXY, but the simpler fix is to just not set HTTP_PROXY for Codex. The intercept mode introduced a cascade of breakage: - HTTPS can't be transparently intercepted (needs CONNECT method) - Image version bumps required lock file recompilation - host.docker.internal traffic crashed Squid under load - Multiple PRs needed to fix each regression This reverts to the pre-#520 explicit proxy mode (HTTP_PROXY/HTTPS_PROXY pointing to Squid port 3128) which worked for all engines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reverts the following PRs which introduced unnecessary complexity: - #520: fix: enable Squid intercept mode for NAT-redirected traffic - v0.13.5 release: chore(release): bump version to 0.13.5 - #524: fix: remove HTTP_PROXY/HTTPS_PROXY env vars from agent container - #526: chore: recompile workflow lock files for AWF v0.13.5 - #527: fix: recompile lock files with release action mode - #522: fix: mount /etc/hosts in chroot and fix HTTP blocking test - #530: fix: restore HTTPS_PROXY, fix chroot hosts/permissions, fix Bun crash - v0.13.6 release: chore(release): bump version to 0.13.6 The intercept mode (#520) was introduced to fix Codex failing with HTTP_PROXY, but the simpler fix is to just not set HTTP_PROXY for Codex. The intercept mode introduced a cascade of breakage: - HTTPS can't be transparently intercepted (needs CONNECT method) - Image version bumps required lock file recompilation - host.docker.internal traffic crashed Squid under load - Multiple PRs needed to fix each regression This reverts to the pre-#520 explicit proxy mode (HTTP_PROXY/HTTPS_PROXY pointing to Squid port 3128) which worked for all engines. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
--action-mode release --action-tag v0.42.0./actions/setup→github/gh-aw/actions/setup@SHAreferenceProblem
PR #526 was compiled in dev mode, which uses
./actions/setup(local path) instead ofgithub/gh-aw/actions/setup@a7134347...(pinned remote action). Since theactions/setupdirectory doesn't exist in this repo, all activation jobs fail with:Test plan
./actions/setuperrors)🤖 Generated with Claude Code