Skip to content

fix: prevent docker output from contaminating command stdout #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Feb 12, 2026
+3 −3
Merged

fix: prevent docker output from contaminating command stdout #743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7064881
Initial plan
Claude Feb 12, 2026
9d750d6
fix: prevent docker output from contaminating command stdout
Claude Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/docker-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,7 @@ export async function startContainers(workDir: string, allowedDomains: string[],
}
await execa('docker', composeArgs, {
cwd: workDir,
stdio: 'inherit',
stdio: ['ignore', 'ignore', 'inherit'], // Only inherit stderr for errors, ignore stdout to prevent container names appearing in output
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdio: ['ignore', 'ignore', 'inherit'] also changes stdin from inherited to ignored. If the goal is only to suppress Docker stdout, consider inheriting stdin and only ignoring stdout (e.g., keep stdin as inherit) to avoid an unnecessary behavior change for interactive/TTY-sensitive Docker commands.

This issue also appears on line 1136 of the same file.

Suggested change
stdio: ['ignore', 'ignore', 'inherit'], // Only inherit stderr for errors, ignore stdout to prevent container names appearing in output
stdio: ['inherit', 'ignore', 'inherit'], // Only inherit stderr for errors, ignore stdout to prevent container names appearing in output

Copilot uses AI. Check for mistakes.
});
logger.success('Containers started successfully');

Expand Down Expand Up @@ -1307,7 +1307,7 @@ export async function stopContainers(workDir: string, keepContainers: boolean):
// Normal path: use docker compose down
await execa('docker', ['compose', 'down', '-v'], {
cwd: workDir,
stdio: 'inherit',
stdio: ['ignore', 'ignore', 'inherit'], // Ignore stdout to prevent container names appearing in output
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stopContainers() unit tests currently expect docker compose down -v to be invoked with stdio: 'inherit', but this call now uses a different stdio config. Also, stopContainers() only takes the compose-down branch when docker-compose.yml exists; the test should either create that file to exercise this branch or update expectations to match the fallback path.

Suggested change
stdio: ['ignore', 'ignore', 'inherit'], // Ignore stdout to prevent container names appearing in output
stdio: 'inherit',

Copilot uses AI. Check for mistakes.
});
logger.success('Containers stopped successfully');
} else {
Expand All @@ -1322,7 +1322,7 @@ export async function stopContainers(workDir: string, keepContainers: boolean):
const { stdout } = await execa('docker', ['ps', '-aq', '-f', `name=^${name}$`]);
if (stdout.trim()) {
logger.debug(`Stopping container: ${name}`);
await execa('docker', ['rm', '-f', name], { stdio: 'inherit' });
await execa('docker', ['rm', '-f', name], { stdio: ['ignore', 'ignore', 'inherit'] }); // Ignore stdout to prevent container names appearing in output
}
} catch (err) {
logger.debug(`Could not stop container ${name}:`, err);
Expand Down
Loading