Fix code scanning alert no. 2: Prototype-polluting function#712
Merged
decyjphr merged 1 commit intomain-enterprisefrom Dec 17, 2024
Merged
Fix code scanning alert no. 2: Prototype-polluting function#712decyjphr merged 1 commit intomain-enterprisefrom
decyjphr merged 1 commit intomain-enterprisefrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
lib/mergeDeep.js:95
- The added condition correctly prevents prototype pollution by skipping the
__proto__andconstructorproperties during the merge process.
if (key === "__proto__" || key === "constructor") {
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Collaborator
|
Thanks @lindluni |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/safe-settings/security/code-scanning/2
To fix the prototype pollution vulnerability, we need to ensure that properties like
__proto__andconstructorare not merged into themodifications,additions, ordeletionsobjects. This can be achieved by adding checks to skip these properties during the merge process.The best way to fix the problem without changing existing functionality is to add a condition to skip these properties in the
compareDeepmethod. Specifically, we will add a check before processing each key to ensure it is not__proto__orconstructor.Suggested fixes powered by Copilot Autofix. Review carefully before merging.