Fixes #1651 - Adds an option to open a file on click in Search & Compare#3583
Open
EhabY wants to merge 5 commits intogitkraken:mainfrom
Open
Fixes #1651 - Adds an option to open a file on click in Search & Compare#3583EhabY wants to merge 5 commits intogitkraken:mainfrom
EhabY wants to merge 5 commits intogitkraken:mainfrom
Conversation
48b5b7d to
0948fd6
Compare
Author
|
@eamodio Merged main into this branch, ready for review 🙏 |
EhabY
commented
Jul 12, 2025
Comment on lines
+174
to
+176
| return createCommand<[CommitFileNodeBase<Type, TView>, OpenFileAtRevisionCommandArgs]>( | ||
| 'gitlens.views.openFileRevision', | ||
| 'Open File at Revision', |
Author
There was a problem hiding this comment.
This relies on reusing the logic from the context menu item "Open File at Revision". The alternative is to use the generic command gitlens.openFileRevision and copy the logic to get the revision URI:
const revisionUri =
node.commit.file?.status === 'D'
? this.container.git
.getRepositoryService(node.commit.repoPath)
.getRevisionUri(
(await node.commit.getPreviousSha()) ?? deletedOrMissing,
node.commit.file.path,
)
: this.container.git.getRevisionUriFromGitUri(node.uri);However this would require making this method async which wouldn't work :/
EhabY
commented
Jul 12, 2025
| const filesConfig = this.view.config.files; | ||
| if ('openDiffOnClick' in filesConfig && filesConfig.openDiffOnClick === false) { | ||
| return createCommand<[CommitFileNodeBase<Type, TView>, OpenFileAtRevisionCommandArgs]>( | ||
| 'gitlens.views.openFileRevision', |
Author
There was a problem hiding this comment.
Should this open the file at the revision or open current file? The context menu item has both "Open File" and "Open File at Revision" and same for the icons, though clicking the icon without [Alt] would open the file at the revision so I opted to make that the default for a single click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1651. This PR adds an option in the GitLens settings to open the file when clicking on its entry in the Search & Compare instead of opening the diff view.
Since this issue was only for the Search & Compare, I only added this settings for this view. If there is need to add it to the other views then I can do that as well. Supersedes #2845 since that one seems to be stale now.
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses