fix: support comma-containing values in --docker-build-options #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change flag type from StringToString to StringArray to prevent comma-based splitting of option values. This allows docker buildx cache options like cache-to=type=gha,mode=max to work correctly. Co-authored-by: Ona <no-reply@ona.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
--docker-build-optionsflag usedStringToStringwhich parses values as comma-separated key=value pairs. This breaks Docker buildx cache options that contain commas in their values (e.g.,cache-to=type=gha,mode=max).Changed to
StringArrayflag type so each repeated flag is a complete option without comma-based splitting.Before:
leeway build --docker-build-options=cache-to=type=gha,mode=max # Parsed as: --cache-to type=gha AND --mode max (broken)After:
leeway build --docker-build-options=cache-to=type=gha,mode=max # Parsed as: --cache-to=type=gha,mode=max (correct)Related Issue(s)
Fixes the docker-build-options comma parsing issue.
How to test