Fix concurrency races, error handling, and lint warnings#22
Merged
Conversation
Owner
glebovdev
commented
Feb 15, 2026
glebovdev
commented
- Wait for sub-goroutines in Player.Stop() before resetting state
- Guard StartPeriodicRefresh against double-start, capture locals for goroutine
- Fix data race in refresh background logging
- Add HTTP status check to PLS fetching
- Prevent stale async image from overwriting current station logo
- Stop existing animation goroutine before starting new one on error retry
- Fix SA5011 staticcheck warnings in tests (make check now passes clean)
- Wait for sub-goroutines in Player.Stop() before resetting state - Guard StartPeriodicRefresh against double-start, capture locals for goroutine - Fix data race in refresh background logging - Add HTTP status check to PLS fetching - Prevent stale async image from overwriting current station logo - Stop existing animation goroutine before starting new one on error retry - Fix SA5011 staticcheck warnings in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.