Switch from jzarr to zarr-java for v2/NGFF 0.4 #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zarr-java 0.0.10 has been released now. Are you holding of with a new release for this PR? Would be nice do have a release with the |
Member
Author
|
Mentioned separately, but note that 0.12.0-rc1 includes the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully removes the dependency on jzarr, and uses zarr-java for all versions.
There are a few test failures here, which are specific to v2 plate data. See note in
Converterline 2816. Since there have been a few relevant fixes in zarr-java since 0.0.9 (especially zarr-developers/zarr-java#36), I expect to keep this as a draft until a new zarr-java version is released.There are also a few commented to-do items around compression properties (likely needs documentation in addition to code changes), and testing of group key counts.