JPEG-2000 compression based refactoring#32
Open
chris-allan wants to merge 20 commits intoglencoesoftware:masterfrom
Open
JPEG-2000 compression based refactoring#32chris-allan wants to merge 20 commits intoglencoesoftware:masterfrom
chris-allan wants to merge 20 commits intoglencoesoftware:masterfrom
Conversation
Firstly, `NamedTemporaryFile` cannot be opened more than once on Windows; the implementation was effectively broken completely on the platform. Consequently, temporary file usage has been moved to `mkstemp()` and handled accordingly. Furthermore, the `out` argument to the JPEG-2000 codec `Codec.decode()` implementation was not being handled correctly causing visual corruption with certain workflows (noteably napari). As of this commit glymur 0.9.4 is required and the constructor based API is now in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the codebase such that all compression is performed by imagecodecs using a JPEG-2000 codec for Zarr.
NOTE: Due to the Python 3.7+ requirements of some of the dependencies used in this PR and the availability of the iSyntax SDK for Python 3.7 currently being restricted to Windows it will only run on that platform.
This PR can be executed as regular isyntax2raw with the exception of the
--psnrcommand line option. NOTE: This option is fed directly into imagecodecs and may need to be inversed depending on the version installed (--psnr=60being equivalent to 40 PSNR). For example:Testing of the result can be performed on the same platform and Python environemnt with
napari; assuming1.isyntaxhas been converted to1.zarras above. For example:This testing with
naparican happen on any platform with Python 3.7+ utilizing the JPEG-2000 Codec factored out and published to PyPI aszarr-jpeg2k:Latest wheel: