Skip to content

fix: improve visibility of waiting indicator in plan connect modals #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin-on merged 2 commits into from
Jan 27, 2026
Merged

fix: improve visibility of waiting indicator in plan connect modals #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a56ee32
fix: improve visibility of waiting indicator in plan connect modals
kevin-on Jan 27, 2026
7518a31
fix: fix lint
kevin-on Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/settings/modals/ConnectGeminiPlanModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,15 @@ function ConnectGeminiPlanModalComponent({
/>
{isWaitingForCallback && (
<div className="smtcmp-plan-connect-waiting">
Waiting for authorization...
<div className="smtcmp-plan-connect-waiting-content">
<div className="smtcmp-plan-connect-waiting-spinner" />
<div className="smtcmp-plan-connect-waiting-text">
<strong>Waiting for authorization</strong>
<span>
Complete the login in your browser, then return here
</span>
</div>
</div>
</div>
)}
</ObsidianSetting>
Expand Down
10 changes: 9 additions & 1 deletion src/components/settings/modals/ConnectOpenAIPlanModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,15 @@ function ConnectOpenAIPlanModalComponent({
/>
{isWaitingForCallback && (
<div className="smtcmp-plan-connect-waiting">
Waiting for authorization...
<div className="smtcmp-plan-connect-waiting-content">
<div className="smtcmp-plan-connect-waiting-spinner" />
<div className="smtcmp-plan-connect-waiting-text">
<strong>Waiting for authorization</strong>
<span>
Complete the login in your browser, then return here
</span>
</div>
</div>
</div>
)}
</ObsidianSetting>
Expand Down
47 changes: 45 additions & 2 deletions styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1872,8 +1872,51 @@ button.smtcmp-chat-input-model-select {
}

.smtcmp-plan-connect-waiting {
margin-top: var(--size-2-1);
font-size: var(--font-ui-small);
margin: var(--size-4-3) 0;
padding: var(--size-4-3);
background: var(--background-modifier-info);
border: 1px solid var(--background-modifier-border);
border-left: 3px solid var(--interactive-accent);
border-radius: var(--radius-s);
}

.smtcmp-plan-connect-waiting-content {
display: flex;
align-items: center;
gap: var(--size-4-3);
}

.smtcmp-plan-connect-waiting-spinner {
width: 20px;
height: 20px;
border: 2px solid var(--background-modifier-border);
border-top-color: var(--interactive-accent);
border-radius: 50%;
animation: smtcmp-spin 0.8s linear infinite;
flex-shrink: 0;
}

@keyframes smtcmp-spin {
from {
transform: rotate(0deg);
}
to {
transform: rotate(360deg);
}
}

.smtcmp-plan-connect-waiting-text {
display: flex;
flex-direction: column;
gap: 2px;
}

.smtcmp-plan-connect-waiting-text strong {
color: var(--text-normal);
}

.smtcmp-plan-connect-waiting-text span {
font-size: var(--font-ui-smaller);
color: var(--text-muted);
}

Expand Down