Skip to content

Conversation

@MyvTsv
Copy link
Contributor

@MyvTsv MyvTsv commented Feb 3, 2026

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !41547
  • Hide inventory rules that the user does not have read access to in the same way as rules in the ‘Other rules’ category.

Screenshots (if appropriate):

Rights:
image

View
image

@MyvTsv MyvTsv self-assigned this Feb 3, 2026
@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz February 3, 2026 14:09
@stonebuzz
Copy link
Contributor

If the user has no permissions on rules (globally), should GLPI display the ‘Rules’ menu at all?

@trasher
Copy link
Contributor

trasher commented Feb 3, 2026

I'm not sure for the view.
The goal was to explain to the user what is the process of all the rules during inventory; and in your new view, one may understand there are only 2 steps.
I guess all steps must always be present; and in this case, just remove the link to the page when they do not have access.

@trasher
Copy link
Contributor

trasher commented Feb 3, 2026

If the user has no permissions on rules (globally), should GLPI display the ‘Rules’ menu at all?

And probably, yes

Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@stonebuzz
Copy link
Contributor

Agree with @trasher

@MyvTsv MyvTsv requested a review from trasher February 5, 2026 08:27
@stonebuzz
Copy link
Contributor

A red border seems to indicate a problem (which is not the case).

image

@stonebuzz
Copy link
Contributor

Moreover, if I enable the permission on software dictionaries or on business rules for tickets, the tile remains unclickable and red (I should be able to access it).

Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the visual, red is indeed misleading, so we could possibly slightly gray out what is not accessible and change the cursor:
cursor: not-allowed;

@MyvTsv MyvTsv requested a review from Rom1-B February 5, 2026 15:58
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a tooltip on hover over the tile indicating “You do not have the required permissions”?

@MyvTsv MyvTsv requested a review from stonebuzz February 6, 2026 10:35
@stonebuzz stonebuzz requested a review from cedric-anne February 9, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants