Fixing CLI usage not having enough rights in GLPI's profile system

[C-Duv]

Checklist before requesting a review

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.

Description

• It fixes user:reset_password console command gets an error #22931
• Here is a brief description of what this PR does:
  Adds a check for CLI execution in Profile::currentUserHaveMoreRightThan() so it can grants it rights if needed.

[trasher]

This breaks tests

[cedric-anne]

IMHO, it is preferable to combine the usage of Session::callAsSystem() in the command with a Session::isRightChecksDisabled() check in the Profile::currentUserHaveMoreRightThan() method.

[C-Duv]

IMHO, it is preferable to combine the usage of Session::callAsSystem() in the command with a Session::isRightChecksDisabled() check in the Profile::currentUserHaveMoreRightThan() method.

@cedric-anne Something like that?

 src/Glpi/Console/User/ResetPasswordCommand.php | 3 +--
 src/Profile.php                                | 5 ++++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/Glpi/Console/User/ResetPasswordCommand.php b/src/Glpi/Console/User/ResetPasswordCommand.php
index 05d211fd55..e234f5f172 100644
--- a/src/Glpi/Console/User/ResetPasswordCommand.php
+++ b/src/Glpi/Console/User/ResetPasswordCommand.php
@@ -76,8 +76,7 @@ class ResetPasswordCommand extends AbstractUserCommand
         $user_input['password'] = $password;
         $user_input['password2'] = $password;
 
-
-        if ($user->update($user_input)) {
+        if (Session::callAsSystem(fn() => $user->update($user_input))) {
             $output->writeln('<info>' . __('Reset password successful.') . '</info>');
             return 0;
         } else {
diff --git a/src/Profile.php b/src/Profile.php
index 047eed3522..cfbec75846 100644
--- a/src/Profile.php
+++ b/src/Profile.php
@@ -743,7 +743,10 @@ class Profile extends CommonDBTM implements LinkableToTilesInterface
     {
         global $DB;
 
-        if (Session::isCron()) {
+        if (
+            Session::isRightChecksDisabled()
+            || Session::isCron()
+        ) {
             return true;
         }
         if (count($IDs) === 0) {

[cedric-anne]

Could you please validate it works as expected? According to the lint test failure, you did not test it, or you would have detect the failure.

[cedric-anne]

Suggested change

	if (Session::callAsSystem(fn() => $user->update($user_input))) {
	if (\Session::callAsSystem(fn() => $user->update($user_input))) {

[C-Duv]

Will do

[C-Duv]

Fix applied, it made vendor/bin/phpstan analyze happy.

(and the code still fixes #22931)