Skip to content

Conversation

@f2cmb
Copy link
Contributor

@f2cmb f2cmb commented Feb 4, 2026

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

Add an uploader to documents modal for new KB/

Screenshots (if appropriate):

@f2cmb f2cmb linked an issue Feb 4, 2026 that may be closed by this pull request
@cconard96
Copy link
Contributor

cconard96 commented Feb 4, 2026

Unless this design is only going to be used for KB, IMO it should be made its own component and not put in the KB styles/code.

@f2cmb f2cmb marked this pull request as ready for review February 5, 2026 13:30
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the upload to tmp part should start immediately when the file is added, that's how it works on gmail for example.

Also, if I upload a file that is not allowed (a .json for example), I don't have any error and my file is just silently ignored.

@f2cmb
Copy link
Contributor Author

f2cmb commented Feb 9, 2026

Removed dead code for file verification. Add immediate uploads.

Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good functionally but I'd like to wait for @cedric-anne opinion on the technical side as this changes a lot compared to our traditional "legacy" jquery file uploader system.

If we validate it, it should indeed be move into a re-usable module so it can be used for others features as a replacement of the old jquery file uploader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Functional upload modal

3 participants