-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
add drag uploader #23011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add drag uploader #23011
Conversation
|
Unless this design is only going to be used for KB, IMO it should be made its own component and not put in the KB styles/code. |
AdrienClairembault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the upload to tmp part should start immediately when the file is added, that's how it works on gmail for example.
Also, if I upload a file that is not allowed (a .json for example), I don't have any error and my file is just silently ignored.
51782e3 to
aa0a441
Compare
|
Removed dead code for file verification. Add immediate uploads. |
AdrienClairembault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good functionally but I'd like to wait for @cedric-anne opinion on the technical side as this changes a lot compared to our traditional "legacy" jquery file uploader system.
If we validate it, it should indeed be move into a re-usable module so it can be used for others features as a replacement of the old jquery file uploader.
Description
Add an uploader to documents modal for new KB/
Screenshots (if appropriate):