Make it work on macOS and update to QT 6.x#6
Open
moreaki wants to merge 2 commits intognudles:mac_integrationfrom
Open
Make it work on macOS and update to QT 6.x#6moreaki wants to merge 2 commits intognudles:mac_integrationfrom
moreaki wants to merge 2 commits intognudles:mac_integrationfrom
Conversation
gnudles
reviewed
Jan 18, 2024
glmodelview.cpp
Outdated
| program.link(); | ||
| program.bind(); | ||
| QOpenGLShaderProgram *program; | ||
| program = new QOpenGLShaderProgram(this); |
Owner
There was a problem hiding this comment.
Where is this memory allocation getting released?
Contributor
Author
There was a problem hiding this comment.
Good question ;). I'm a bit swamped with work, but I'll try to update the PR.
Mac integration
Squashed commit of the following: commit e6d8d53 Author: Kapandaria <dvoreader@gmail.com> Date: Thu Feb 27 10:14:39 2025 +0200 Update stereomaker.cpp Scaling with keep aspect ratio probably made the height as zero. commit 94a1123 Author: Kapandaria <dvoreader@gmail.com> Date: Sun Feb 16 14:49:03 2025 +0200 Update stereomaker.cpp commit 5368dd7 Author: Kapandaria <dvoreader@gmail.com> Date: Sun Feb 16 14:01:45 2025 +0200 Update stereomaker.cpp commit 169ad02 Author: Kapandaria <dvoreader@gmail.com> Date: Sun Feb 16 13:55:40 2025 +0200 Update stereomaker.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.