expose http.Handler to serve /metrics separately from main router#15
Open
Grekkq wants to merge 2 commits intogo-chi:masterfrom
Open
expose http.Handler to serve /metrics separately from main router#15Grekkq wants to merge 2 commits intogo-chi:masterfrom
Grekkq wants to merge 2 commits intogo-chi:masterfrom
Conversation
…xposing the metrics on a same server
Grekkq
force-pushed
the
feat/serve-metrics-separately
branch
from
5abae2e to
4b3a01e
Compare
|
I'm also interested in this change. Is there any maintainer that can take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a simple public function to expose the prometheus
reporter.HTTPHandlerto allow exposing metrics on a separate server then the server that collects them.Motivation why it is useful, when running the application inside secure environment it good practice to expose only the public facing api to outside world and keep metrics behind a firewall as they might expose useful informations to malicious users.
Not sure if the current place (next to
Collector()insidecollector.go) is the right one, but I'm willing to do any necessary changes to get this merged, thanks.