SSH Push/Pull Mirroring & Migrations#35089
SSH Push/Pull Mirroring & Migrations#35089techknowlogick wants to merge 26 commits intogo-gitea:mainfrom
Conversation
|
Could the table |
As-in, have the data be duplicated in two tables? I'm not sure what your suggestion is, could you give more details? |
|
I mean the table |
|
And maybe it's better to put all these SSH keys into the same table and manage them together. So that some SSH keys could be used in multiple places with a permission setting. And it will also be easier to invoke them if necessary. |
Why and how? Can you show a real world example that how these keys would be managed and used together in the future? The auto-generated keys are managed by Gitea itself, they are not the same as user's SSH keys for SSH access or sign. If no real world case, then it is an over-design. |
Signed-off-by: techknowlogick <matti@mdranta.net>
Signed-off-by: techknowlogick <matti@mdranta.net>
Signed-off-by: techknowlogick <matti@mdranta.net>
|
yes, as @wxiaoguang said, these keys serve a different purpose. Additionally, they also have the private key included which the other type does not have. |
| @@ -0,0 +1,169 @@ | |||
| // Copyright 2025 The Gitea Authors. All rights reserved. | |||
There was a problem hiding this comment.
Maybe it's better to move this file to models/user package? Why it belongs to repo package?
There was a problem hiding this comment.
And since it could be used for migrating, the file name is inaccurate.
There was a problem hiding this comment.
other mirror/migrate code is in here so that is why it is in here. most other mirror/migrate code is referred to as mirror (except for some specific logic) so I kept the naming the same.
| <div class="fork-flag"> | ||
| {{ctx.Locale.Tr "repo.mirror_from"}} | ||
| <a target="_blank" rel="noopener noreferrer" href="{{$.PullMirror.RemoteAddress}}">{{$.PullMirror.RemoteAddress}}</a> | ||
| {{if not (StringUtils.HasPrefix $.PullMirror.RemoteAddress "ssh://")}} |
| visibility.private = Private | ||
| visibility.private_tooltip = Visible only to members of organizations you have joined | ||
|
|
||
| mirror_ssh_title = Repository Mirror SSH Keys |
There was a problem hiding this comment.
Since the keys might be used for migration, the key name should be changed. If the keys maybe used in other places in the future, maybe Auto-Generated SSH Keys or Managed SSH Keys?
…techknowlogick-ssh-mirroring
|
I'm really looking forward to this feature. May I ask when it will be merged? |
|
It would be great if this feature could be included in 1.26.0. |
Add SSH for push/pull mirrors and repo migrations.
Each User/Org gets their own public/private key, and they can rotate/regen it as they please. Users can now use
ssh://git@github.com/go-gitea/gitea.gitas a clone source.Fixes: #26321