Improve timeline entries for WIP prefix changes in pull requests

[Copilot]

Add new timeline event types when the WIP prefix is added or removed, replacing the previous ugly title change messages.

Fixes: #36517

[silverwind]

Tested, works:

[silverwind]

@copilot restore the $createdStr suffix removed in d2d6b91, it's needed.

[lunny]

Maybe a new column is_draft should be added to pull request table.

[silverwind]

Maybe a new column is_draft should be added to pull request table.

If we wanna completely implement it like GitHub, the "WIP" prefix would need to be removed but I guess that would be too breaking for users which may be used to manually adding that prefix, potentially in their git commit message title.

The only gain that a separate is_draft boolean would bring is that when a user manually adds or removes the prefix, we could opt to not set the PR in/out of draft, but in my opinion that's actually desirable behaviour to decide draft status on presence or absence of prefix alone.

[lunny]

Maybe a new column is_draft should be added to pull request table.

If we wanna completely implement it like GitHub, the "WIP" prefix would need to be removed but I guess that would be too breaking for users which may be used to manually adding that prefix, potentially in their git commit message title.

The only gain that a separate is_draft boolean would bring is that when a user manually adds or removes the prefix, we could opt to not set the PR in/out of draft, but in my opinion that's actually desirable behaviour to decide draft status on presence or absence of prefix alone.

Another benefit is that it could be used as a filter option in the pull request list.

[silverwind]

Another benefit is that it could be used as a filter option in the pull request list.

Hmm yes I agree but can be added in another PR imho. It will be a bit complex because it requires a migration. I would like to keep this PR focused on only adjusting the timeline messages.

[silverwind]

AGENTS.md is further slimmed down. The removed instructions are unnecessary for a somewhat smart agent and a non-issue with local agents.

[lunny]

The issue https://github.com/go-gitea/gitea/pull/36518/files#r2765306365 need to be resovled.

[wxiaoguang]

We need those new comment types, they differ by icon and I want them to match GitHub:

No, you can still have different icons by #36518 (comment), it's clearer and simpler.

And it's easier to "cover that case user edit title and changed wip prefix also title at the same time".

[silverwind]

I don't understand "cover that case user edit title and changed wip prefix also title at the same time".

These are two distinct actions on the UI, one is a title edit and there's the wip toggle button. How could those be triggered at the same time?

[silverwind]

You can "fix" #36517 by checking the old/new titles when rendering the timeline item without introducing more CommentType.

What kind of timeline item should it use? Is there a a generic type?

[wxiaoguang]

I don't understand "cover that case user edit title and changed wip prefix also title at the same time".

These are two distinct actions on the UI, one is a title edit and there's the wip toggle button. How could those be triggered at the same time?

Edit the title manually

You can "fix" #36517 by checking the old/new titles when rendering the timeline item without introducing more CommentType.

What kind of timeline item should it use? Is there a a generic type?

<div timeline>
   <badge> $item.IconName </badge>
   <content> $item.Content </content>
</div>

[silverwind]

Edit the title manually

Ah, a title edit with wip state change, yes in this case it needs to show the rename timeline item.