feat: add option early return in case of error#1374
Open
thenicolau wants to merge 3 commits intogo-playground:masterfrom
Open
feat: add option early return in case of error#1374thenicolau wants to merge 3 commits intogo-playground:masterfrom
thenicolau wants to merge 3 commits intogo-playground:masterfrom
Conversation
Contributor
Author
|
resolve Issue - 1371 |
Contributor
|
Asking about the use case here to learn if it's worth saving a few nanoseconds|microseconds :) #1371 (comment) |
Contributor
Author
|
I noticed that this old PR had a merge problem, and the issue linked to it was also updated, so I fixed the issues and it is now ready to be reviewed again |
zemzale
approved these changes
Dec 19, 2025
Member
zemzale
left a comment
There was a problem hiding this comment.
Just as mentioned before I am not sure about the use case. Not that it's invalid, but more if we actually want to add this to the library.
But the code looks good, so approving the code change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers